[PATCH v6 00/14] mtd: spi-nor: Add support for Cypress s25hl-t/s25hs-t

[Pratyush Yadav]

On 26/04/21 06:25PM, Jagan Teki wrote:
> On Mon, Apr 26, 2021 at 6:19 PM Pratyush Yadav <p.yadav at ti.com> wrote:
> >
> > On 26/04/21 06:04PM, Jagan Teki wrote:
> > > On Mon, Apr 26, 2021 at 12:30 PM Takahiro Kuwano <tkuw584924 at gmail.com> wrote:
> > > >
> > > > Hi Jagan,
> > > >
> > > > On 4/25/2021 9:42 PM, Jagan Teki wrote:
> > > > > On Tue, Apr 20, 2021 at 9:56 AM Takahiro Kuwano <tkuw584924 at gmail.com> wrote:
> > > > >>
> > > > >> On 4/19/2021 4:13 PM, Jagan Teki wrote:
> > > > >>> On Wed, Apr 7, 2021 at 9:01 AM <tkuw584924 at gmail.com> wrote:
> > > > >>>>
> > > > >>>> From: Takahiro Kuwano <Takahiro.Kuwano at infineon.com>
> > > > >>>>
> > > > >>>> The S25HL-T/S25HS-T family is the Cypress Semper Flash with Quad SPI.
> > > > >>>>
> > > > >>>> The summary datasheets can be found in the following links.
> > > > >>>> https://www.cypress.com/file/424146/download (256Mb/512Mb/1Gb, single die)
> > > > >>>> https://www.cypress.com/file/499246/download (2Gb/4Gb, dual/quad die)
> > > > >>>>
> > > > >>>> The full version can be found in the following links (registration
> > > > >>>> required).
> > > > >>>> https://community.cypress.com/t5/Semper-Flash-Access-Program/Datasheet-Semper-Flash-with-Quad-SPI/ta-p/260789?attachment-id=19522
> > > > >>>> https://community.cypress.com/t5/Semper-Flash-Access-Program/Datasheet-2Gb-MCP-Semper-Flash-with-Quad-SPI/ta-p/260823?attachment-id=29503
> > > > >>>>
> > > > >>>> Tested on Xilinx Zynq-7000 FPGA board.
> > > > >>>
> > > > >>> Any details about footprint statistics?
> > > > >>>
> > > > >> Please see arm-none-eabi-size output below.
> > > > >>
> > > > >> BEFORE patching:
> > > > >>    text    data     bss     dec     hex filename
> > > > >>    6353       0       0    6353    18d1 drivers/mtd/spi/spi-nor-core.o
> > > > >>     922       0       0     922     39a drivers/mtd/spi/spi-nor-ids.o
> > > > >>    1879       0       0    1879     757 spl/drivers/mtd/spi/spi-nor-tiny.o
> > > > >>
> > > > >> AFTER patching:
> > > > >>    text    data     bss     dec     hex filename
> > > > >>    7705      12       0    7717    1e25 drivers/mtd/spi/spi-nor-core.o
> > > > >>    1150       0       0    1150     47e drivers/mtd/spi/spi-nor-ids.o
> > > > >>    1919       0       0    1919     77f spl/drivers/mtd/spi/spi-nor-tiny.o
> > > > >>
> > > > >> arm-none-eabi-gcc (GCC) 8.2.0, Optimization level -O2.
> > > > >
> > > > > Does this series depend on any other patches or Octal DTR?
> > > >
> > > > No. This series is for Quad SPI parts and independent from any other patches.
> > > > The #1, #2, and #3 patches in this series come from Pratyush's series [0]
> > > > that adds Octal DTR support. However, those three patches introduce generic
> > > > hooks and do not contain any specific changes for Octal DTR.
> > >
> > > nor->erase seems improper, please have a look at the issue here.
> > > https://source.denx.de/u-boot/custodians/u-boot-spi/-/jobs/260932
> >
> > I get a 404 on this link. Can you elaborate on what is wrong with
> > nor->erase?
> 
> Building current source for 1 boards (0 threads, 40 jobs per thread)
> sandbox: w+ sandbox_spl
> + nor->erase = s25hx_t_erase_non_uniform;
> + ^
> w+drivers/mtd/spi/spi-nor-core.c: In function 's25hx_t_setup':
> w+drivers/mtd/spi/spi-nor-core.c:2733:14: warning: assignment from
> incompatible pointer type [-Wincompatible-pointer-types]
> 0 1 0 /1 sandbox_spl

Sandbox defines ssize_t as long and ARM defines it as int and so on. 
nor->erase() returns int, so this would build fine on 32-bit platforms 
but not on 64-bit ones. Changing the return type of s25hx_t_setup() to 
int should fix this problem.

> 
> Can you able to open this link at least?
> 
> https://source.denx.de/u-boot/custodians/u-boot-spi/-/pipelines/7306

Yes.

-- 
Regards,
Pratyush Yadav
Texas Instruments Inc.