[PATCH] usb: musb-new: Extend Allwinner quirk to newer SoCs

Marek Vasut marex at denx.de
Tue Apr 27 02:37:20 CEST 2021


On 4/27/21 2:03 AM, Andre Przywara wrote:
> As the comment in musb_regs.h describes, Allwinner saves the
> MUSB_CONFIGDATA register, which always return 0 on those SoCs.
> 
> This is also true for the H6 and H616, so extend the quirk to those
> controllers as well.
> 
> This fixes USB peripheral mode on H6 and H616 boards.
> 
> Signed-off-by: Andre Przywara <andre.przywara at arm.com>
> ---
>   drivers/usb/musb-new/musb_regs.h | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/musb-new/musb_regs.h b/drivers/usb/musb-new/musb_regs.h
> index c4d7203b851..bee1b715a95 100644
> --- a/drivers/usb/musb-new/musb_regs.h
> +++ b/drivers/usb/musb-new/musb_regs.h
> @@ -432,7 +432,8 @@ static inline u8 musb_read_ulpi_buscontrol(void __iomem *mbase)
>   static inline u8 musb_read_configdata(void __iomem *mbase)
>   {
>   #if defined CONFIG_MACH_SUN8I_A33 || defined CONFIG_MACH_SUN8I_A83T || \
> -		defined CONFIG_MACH_SUNXI_H3_H5 || defined CONFIG_MACH_SUN50I
> +	defined CONFIG_MACH_SUNXI_H3_H5 || defined CONFIG_MACH_SUN50I || \
> +	defined CONFIG_SUN50I_GEN_H6

Isn't there some better solution then ever-growing list of macros to 
check, like e.g. a single CONFIG_MACH_SUNXI ?


More information about the U-Boot mailing list