[PATCH 1/4] arm: mvebu: armada-3720-uDPU.dts: Change back to phy-mode "2500base-x"

[Stefan Roese]

Hi Jakov,

On 27.04.21 14:57, Jakov Petrina wrote:
> Hi Stefan,
> 
> On 27/04/2021 11:48, Stefan Roese wrote:
>> With commit 8678776df6f5 (arm: mvebu: armada-3720-uDPU: fix PHY mode
>> definition to sgmii-2500) the PHY mode was switch to "sgmii-2500", even
>> when this is functionally incorrect since "2500base-x" was not supported
>> in U-Boot at that time. As this mode is now supported (at least present
>> in the headers), this patch moves back to the orinal version.
>>
> 
> thanks, great to hear that the "2500base-x" PHY mode is now supported in 
> U-Boot.

I see just now, that I somehow forgot to send the corresponding changes
to the mvpp2 driver, which include this addition of "2500base-x" to
phy_interfaces.h. I'll send those patches shortly.

Thanks,
Stefan

>> Signed-off-by: Stefan Roese <sr at denx.de>
>> Cc: Jakov Petrina <jakov.petrina at sartura.hr>
>> Cc: Vladimir Vid <vladimir.vid at sartura.hr>
>> Cc: Luka Perkov <luka.perkov at sartura.hr>
>> ---
>> Jakov, Vladimir: This is completely untested. Could you please review
>> and let me know, if this works for you?
>>
> 
> Unfortunately, I don't have the required hardware with me so I am not 
> able to test the change.
> 
> Regards,
> 
> Jakov
> 
>> Thanks,
>> Stefan
>>
>>   arch/arm/dts/armada-3720-uDPU.dts | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/dts/armada-3720-uDPU.dts 
>> b/arch/arm/dts/armada-3720-uDPU.dts
>> index 4b30f3cea8c7..4bf6d2eac798 100644
>> --- a/arch/arm/dts/armada-3720-uDPU.dts
>> +++ b/arch/arm/dts/armada-3720-uDPU.dts
>> @@ -126,14 +126,14 @@
>>   &eth0 {
>>       pinctrl-0 = <&pcie_pins>;
>>       status = "okay";
>> -    phy-mode = "sgmii-2500";
>> +    phy-mode = "2500base-x";
>>       managed = "in-band-status";
>>       phy = <&ethphy0>;
>>   };
>>   &eth1 {
>>       status = "okay";
>> -    phy-mode = "sgmii-2500";
>> +    phy-mode = "2500base-x";
>>       managed = "in-band-status";
>>       phy = <&ethphy1>;
>>   };
>>


Viele Grüße,
Stefan

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de