[EXT] [PATCH v1 05/10] net: mvpp2: Fix 2.5G GMII_SPEED configurations

[Kostya Porotchkin]

Hi, Stefan,

> -----Original Message-----
> From: Stefan Roese <sr at denx.de>
> Sent: Tuesday, April 27, 2021 16:27
> To: u-boot at lists.denx.de
> Cc: Stefan Chulski <stefanc at marvell.com>; Marcin Wojtas
> <mw at semihalf.com>; Nadav Haklai <nadavh at marvell.com>; Marek Behun
> <marek.behun at nic.cz>; Joe Hershberger <joe.hershberger at ni.com>; Kostya
> Porotchkin <kostap at marvell.com>; Yan Markman
> <ymarkman at marvell.com>; sa_ip-sw-jenkins <sa_ip-sw-
> jenkins at marvell.com>
> Subject: [EXT] [PATCH v1 05/10] net: mvpp2: Fix 2.5G GMII_SPEED
> configurations
> 
> External Email
> 
> ----------------------------------------------------------------------
> From: Stefan Chulski <stefanc at marvell.com>
> 
> GMII_SPEED should be enabled for 2.5G speed
> 
> Signed-off-by: Stefan Chulski <stefanc at marvell.com>
> Reviewed-by: Yan Markman <ymarkman at marvell.com>
> Reviewed-by: Kostya Porotchkin <kostap at marvell.com>
> Tested-by: sa_ip-sw-jenkins <sa_ip-sw-jenkins at marvell.com>
> Signed-off-by: Stefan Roese <sr at denx.de>
> ---
> 
>  drivers/net/mvpp2.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mvpp2.c b/drivers/net/mvpp2.c index
> 2043bdf10aa4..ec7cb89a94c8 100644
> --- a/drivers/net/mvpp2.c
> +++ b/drivers/net/mvpp2.c
> @@ -4445,7 +4445,8 @@ static void mvpp2_link_event(struct mvpp2_port
> *port)
>  			if (phydev->duplex)
>  				val |= MVPP2_GMAC_CONFIG_FULL_DUPLEX;
> 
> -			if (phydev->speed == SPEED_1000)
> +			if (phydev->speed == SPEED_1000 ||
> +			    phydev->speed == 2500)
[KP] Shouldn't it be "SPEED_2500"?

>  				val |= MVPP2_GMAC_CONFIG_GMII_SPEED;
>  			else if (phydev->speed == SPEED_100)
>  				val |= MVPP2_GMAC_CONFIG_MII_SPEED;
> --
> 2.31.1