[PATCH v1 00/23] phy: marvell: Sync Armada 3k/7k/8k SERDES code with Marvell version

Stefan Roese sr at denx.de
Thu Apr 29 11:00:17 CEST 2021

Hi Marek,

(Added Tom and Simon to Cc)

On 29.04.21 10:27, Marek Behun wrote:
> On Thu, 29 Apr 2021 08:46:36 +0200
> Stefan Roese <sr at denx.de> wrote:
>>>     phy: marvell: add RX training command
>> Applied to u-boot-marvell/master
>> Thanks,
>> Stefan
> Stefan, do you think it would make sense to at least create a special
> mechanism for these platform commands? For example via a top-level
> command "plat", i.e. instead of
>    > rx_training params
> we would call
>    > plat rx_training params
> The plat command could list all registered platform specific commands...

Not sure. If you want to split it up, then we would perhaps also
need to add a mechanism for board specific commands as well. E.g. for
commands not common for a platform but only for specific boards. My
feeling is that this makes things overly complex. And I also don't see
a real problem with the current "flat" structure of these commands
being "global". Again, I mention the many already existing board and
platform specific commands in current mainline.

Perhaps other people can comment on this use / introduction of
platform specific U-Boot commands?

BTW: Again, we can definitely rename this specific "rx_training"
command, if you feel this is absolutely misleading. IIRC, then I already
made a suggestion for this.


More information about the U-Boot mailing list