[PATCH v1 08/10] net: mvpp2: fix missing switch case break

Stefan Roese sr at denx.de
Fri Apr 30 06:40:02 CEST 2021


On 29.04.21 22:24, Ramon Fried wrote:
> On Tue, Apr 27, 2021 at 4:28 PM Stefan Roese <sr at denx.de> wrote:
>>
>> From: Ben Peled <bpeled at marvell.com>
>>
>> Signed-off-by: Ben Peled <bpeled at marvell.com>
>> Reviewed-by: Stefan Chulski <stefanc at marvell.com>
>> Reviewed-by: Kostya Porotchkin <kostap at marvell.com>
>> Tested-by: sa_ip-sw-jenkins <sa_ip-sw-jenkins at marvell.com>
> Please remove this, Jenkins is not a person.

I've left these lines in because most of these patches are plain
cherry-picked from the Marvell SDK.

Should I resubmit this patch only or the complete patchset? Or could you
perhaps remove this line while collecting the patches for a pull
request?

Thanks,
Stefan

>> Signed-off-by: Stefan Roese <sr at denx.de>
>> ---
>>
>>   drivers/net/mvpp2.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/net/mvpp2.c b/drivers/net/mvpp2.c
>> index 61a0ea0894a7..3d920e85ffef 100644
>> --- a/drivers/net/mvpp2.c
>> +++ b/drivers/net/mvpp2.c
>> @@ -3247,9 +3247,11 @@ static int gop_gmac_mode_cfg(struct mvpp2_port *port)
>>
>>          case PHY_INTERFACE_MODE_1000BASEX:
>>                  gop_gmac_1000basex_cfg(port);
>> +               break;
>>
>>          case PHY_INTERFACE_MODE_2500BASEX:
>>                  gop_gmac_2500basex_cfg(port);
>> +               break;
>>
>>          case PHY_INTERFACE_MODE_RGMII:
>>          case PHY_INTERFACE_MODE_RGMII_ID:
>> --
>> 2.31.1
>>


Viele Grüße,
Stefan

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de


More information about the U-Boot mailing list