[PATCH v2 2/2] of: addr: Remove call to dev_count_cells() in of_get_address()

Simon Glass sjg at chromium.org
Fri Apr 30 20:13:55 CEST 2021


On Fri, 30 Apr 2021 at 07:17, Bin Meng <bmeng.cn at gmail.com> wrote:
>
> In of_get_address(), there is:
>
>   dev_count_cells(dev, &na, &ns);
>
> followed by:
>
>   bus->count_cells(dev, &na, &ns);
>
> but no codes in between use na/ns, hence the first call is useless.
> By dropping the first call, dev_count_cells() is now useless too.
>
> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>
> ---
>
> Changes in v2:
> - new patch: of: addr: Remove call to dev_count_cells() in of_get_address()
>
>  drivers/core/of_addr.c | 6 ------
>  1 file changed, 6 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>

I wonder why this is now different from linux?


More information about the U-Boot mailing list