[PATCH] Makefile: Fix generation of flash.bin u-boot.itb with binman

Marek Vasut marex at denx.de
Fri Apr 30 20:47:42 CEST 2021

On 4/30/21 8:13 PM, Simon Glass wrote:
> Hi,

Hello Simon,

> On Thu, 29 Apr 2021 at 17:11, Bin Meng <bmeng.cn at gmail.com> wrote:
>> On Sat, Apr 24, 2021 at 8:57 PM Marek Vasut <marex at denx.de> wrote:
>>> On 2/25/21 9:50 PM, Marek Vasut wrote:
>>>> In case binman is enabled, the u-boot.itb is generated using this tool
>>>> and there is no direct u-boot.itb target, but instead the binman tool
>>>> must be invoked. Add support for this case.
>>>> Signed-off-by: Marek Vasut <marex at denx.de>
>>>> Cc: Peng Fan <peng.fan at nxp.com>
>>>> Cc: Stefano Babic <sbabic at denx.de>
>>> This bugfix is still missing from upstream.
> It seems to be missing a Fixes tag?

There are way too many commits related to this to identify specific one.

> I can't really comment on this particular patch as it is up to MX8
> what is done here.

In that case, deciding on this bugfix is up to the maintainer, Stefano.

> But a much better solution is to move this generation stuff to binman,
> instead of all the arch-specific Makefile rules.

Feel free to submit subsequent patch, but this bug should be fixed 
first, improvements can go in later.

More information about the U-Boot mailing list