[PATCH v2 3/4] sf: doc: Add documentation for the 'sf' command

Simon Glass sjg at chromium.org
Sun Aug 1 23:12:56 CEST 2021


Hi Heinrich,

On Sun, 1 Aug 2021 at 13:56, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>
>
>
> On 8/1/21 8:02 PM, Simon Glass wrote:
> > This command is fairly complicated so documentation is useful.
> > Unfortunately I an not sure how the MTD side of things works and cannot
> > find information about that.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > ---
> >
> > Changes in v2:
> > - Many fixes as suggested by Heinrich
> >
> >   doc/usage/index.rst |   1 +
> >   doc/usage/sf.rst    | 241 ++++++++++++++++++++++++++++++++++++++++++++
> >   2 files changed, 242 insertions(+)
> >   create mode 100644 doc/usage/sf.rst
> >
[..]

> For other commands we have mentioned the relvant configuration options.
> Cf. mmc.rst. Could you, please, add a chapter 'Configuration'.
>
> CONFIG_CMD_SF depends on DM_SPI_FLASH [=y] || SPI_FLASH [=y].

OK. Perhaps we need to add some checking to checkpatch?

>
> I think there is no SPI driver left that is not migrated to DM. Can't we
> get rid of either CONFIG_DM_SPI_FLASH or CONFIG_SPI_FLASH?

I hope so. Jagan is the SPI flash maintainer and is on cc.

Regards,
Simon


More information about the U-Boot mailing list