[PATCH 1/1] doc: riscv: flashing SiFive boards
Leo Liang
ycliang at andestech.com
Mon Aug 2 10:50:42 CEST 2021
Hi Bin,
On Wed, Jul 28, 2021 at 05:18:59PM +0800, Bin Meng wrote:
> On Wed, Jul 28, 2021 at 5:03 PM Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
> >
>
> nits: missing
Could you explain what is missing here?
I did not quite catch the point, thanks!
>
> From: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
>
> > We should not use /dev/sda and /dev/sdb in our examples. Users might
> > inadvertently mess up their workstation. Use /dev/sdX instead.
> >
> > Remove console output like '# ' and '> ' which makes copying hard.
> >
> > Set example language to bash for correct syntax-highlighting.
> >
> > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
> > ---
> > doc/board/sifive/unleashed.rst | 20 ++++++++++----------
> > doc/board/sifive/unmatched.rst | 30 +++++++++++++++---------------
> > 2 files changed, 25 insertions(+), 25 deletions(-)
> >
>
> Otherwise
> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
Best regards,
Leo
More information about the U-Boot
mailing list