[PATCH v4 0/7] Arasan sdhci driver updates
Ashok Reddy Soma
ashok.reddy.soma at xilinx.com
Mon Aug 2 12:16:12 CEST 2021
This patch series updates/fixes below things:
- Handle errors from tapdelay functions and return to set_delay()
- Add ZynqMP firmware related enums which are used in sdhci driver
- Replace mmio_write() with firmware call xilinx_pm_request()
- Move tapdelay setting code from tap_delays.c to driver and remove
tap_dealy.c and zynqmp_tap_delay.h
- Change variable name from deviceid to node_id in couple of functions
for consistancy
- Add a workaround for sd card detect stable issue for Versal platforms
- Use set_control_reg from sdhci.c
These patches are based on below microblaze U-Boot 'next' branch.
https://source.denx.de/u-boot/custodians/u-boot-microblaze/-/commits/next
Changes in v4:
- Rebase to latest u-boot-microblaze custodian 'next' branch
- Initialized all enum pm_ioctl_id elements with explicit values
Changes in v3:
- Added new line after return at two places
- As we are seeing issues with SPL flow, keep zynqmp_mmio_write method
to set tapdelay's and DLL resets. Add xilinx_pm_request on top of it
for regular flow.
- Changed the patch title to reflect these changes
- Make the changes on top of patch 4/7 to move the code to zynq_sdhci.c
Changes in v2:
- Split patch 1/7 to two patches, one for zynq_sdhci and other one
for sdhci
- This is the second patch that has been split from 1/7
- This covers changes for sdhci driver separately
- Added a debug print in case of error from set_delay()
- Added comment for why 1ms delay is needed between DLL assert and
release
- Remove mmc->dev->seq_ and use priv->deviceid instead
- Changed return error from -EIO to -ETIMEDOUT in arasan_sdhci_probe()
in card detect state stable workaround
Ashok Reddy Soma (5):
mmc: zynq_sdhci: Return errors from arasan_sdhci_set_tapdelay
mmc: sdhci: Change prototype of set_delay to return errors
mmc: zynq_sdhci: Add xilinx_pm_request() method to set tapdelays
mmc: zynq_sdhci: Move setting tapdelay code to driver
mmc: zynq_sdhci: Use set_control_reg from sdhci.c
T Karthik Reddy (2):
zynqmp_firmware: Add zynqmp firmware related enums
mmc: zynq_sdhci: Wait till sd card detect state is stable
board/xilinx/zynqmp/Makefile | 2 -
board/xilinx/zynqmp/tap_delays.c | 101 -------------
drivers/mmc/sdhci.c | 10 +-
drivers/mmc/zynq_sdhci.c | 242 ++++++++++++++++++++++++++-----
include/sdhci.h | 2 +-
include/zynqmp_firmware.h | 127 ++++++++++++++++
include/zynqmp_tap_delay.h | 21 ---
7 files changed, 338 insertions(+), 167 deletions(-)
delete mode 100644 board/xilinx/zynqmp/tap_delays.c
delete mode 100644 include/zynqmp_tap_delay.h
--
2.17.1
More information about the U-Boot
mailing list