[PATCH v2 1/5] checkpatch: Support wide strings

Simon Glass sjg at chromium.org
Mon Aug 2 21:20:21 CEST 2021


Hi Tom,

On Sat, 31 Jul 2021 at 21:28, Tom Rini <trini at konsulko.com> wrote:
>
> On Sun, Jul 18, 2021 at 02:14:22PM -0600, Simon Glass wrote:
>
> > From: Joe Perches <joe at perches.com>
> >
> > Allow prefixing typical strings with L for wide strings and u for
> > unicode strings.
> >
> > Signed-off-by: Joe Perches <joe at perches.com>
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > ---
> > This was found on LKML:
> >
> > https://lore.kernel.org/lkml/1508280192.6530.31.camel@perches.com/T/
> >
> > It likely wasn't applied because it did not show up in patchwork
> > correctly, due to the patch being inline:
> >
> > https://lore.kernel.org/patchwork/patch/842121/
> >
> > In any case, it needed rebasing and updating to support 'u'.
> >
> > Heinrich, perhaps you can send this upstream since you have the context?
> >
> > Changes in v2:
> > - Add new patch to reduce checkpatch unicode-string spam
> >
> >  scripts/checkpatch.pl | 7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
>
> I'm very much against having checkpatch.pl changes that aren't inside of
> the u_boot area.  We're currently at I believe just 1 (outside of adding
> --u-boot flag) and I'm testing a resync to v5.13 now that just adds one
> more for good reason and is also obvious enough to not get lost.  This
> however will get lost in a future resync so needs to be brought up with
> upstream.

I sent it upstream and Joe seems happy with it this time.

https://lore.kernel.org/patchwork/patch/1470668/

Regards,
Simon


More information about the U-Boot mailing list