[PATCH] test/py: tpm2: Skip tpm pytest based on env variable

T Karthik Reddy tkarthik at xilinx.com
Thu Aug 5 07:56:50 CEST 2021


Hello Tom Rini,

> -----Original Message-----
> From: Tom Rini <trini at konsulko.com>
> Sent: Wednesday, August 4, 2021 8:52 PM
> To: Ashok Reddy Soma <ashokred at xilinx.com>
> Cc: u-boot at lists.denx.de; miquel.raynal at bootlin.com; git <git at xilinx.com>;
> T Karthik Reddy <tkarthik at xilinx.com>
> Subject: Re: [PATCH] test/py: tpm2: Skip tpm pytest based on env variable
> 
> On Fri, Jul 23, 2021 at 06:18:26AM -0600, Ashok Reddy Soma wrote:
> 
> > From: T Karthik Reddy <t.karthik.reddy at xilinx.com>
> >
> > Tpm test cases relies on tpm device setup. Provide an environment
> > variable "env__tpm_device_test_skip = True" to skip the test case if
> > tpm device is not present.
> > Only needed will have to add variable to the py-test framework.
> > Test runs successfully even this variable is absent.
> >
> > Signed-off-by: T Karthik Reddy <t.karthik.reddy at xilinx.com>
> > Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma at xilinx.com>
> 
> Why is this not using boardenv_* like other tests do to disable running?

What I meant here was this test doesn't depend on configuration value from boardenv_*. But it uses env__tpm_device_test_skip
variable from the configuration file. 
I referred test/py/tests/test_sleep.py for writing this test case, hence copied comments as well.
Should I change this NOTE in comment section?

Thanks
T Karthik

> 
> --
> Tom


More information about the U-Boot mailing list