[PATCH] am33xx: Fix USB for am335x boards

[Harald Seiler]

Hi,

On Sat, 2021-08-07 at 14:17 +0300, Matwey V. Kornilov wrote:
> USB nodes were mistakenly disabled in
> 
>     commit 942853dd96df ("arm: dts: Resync BeagleBone device trees")

To be precise, the problem is that only half of the device tree files
were synced.  am33xx.dtsi (and seemingly some more) were skipped,
leading to the symptoms you found.  I think it is likely that the
upstream changes in am33xx.dtsi which we are missing right now will lead
to more regressions of similar nature.

So I'd say we should dig deeper into the problems you encountered while
attempting to just sync the entirety of am33xx.dtsi.  The end goal is
that all device-tree files not ending in `-uboot` match what is in
Linux, so it is inevitable that someone needs to look into this anyway.

-- 
Harald

> This commit is to fix the following issue:
> 
>     starting USB...
>     No working controllers found
>     USB is stopped. Please issue 'usb start' first.
>     starting USB...
>     No working controllers found
> 
> Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0782e8572ce43f521ed6ff15e4a7ab9aa5acdc85
> Fixes: 942853dd96df ("arm: dts: Resync BeagleBone device trees")
> Signed-off-by: Matwey V. Kornilov <matwey.kornilov at gmail.com>
> ---
>  arch/arm/dts/am33xx.dtsi | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/arch/arm/dts/am33xx.dtsi b/arch/arm/dts/am33xx.dtsi
> index ce07cec846..b5093020ee 100644
> --- a/arch/arm/dts/am33xx.dtsi
> +++ b/arch/arm/dts/am33xx.dtsi
> @@ -380,28 +380,24 @@
>  			#address-cells = <1>;
>  			#size-cells = <1>;
>  			ti,hwmods = "usb_otg_hs";
> -			status = "disabled";
>  
>  			usb_ctrl_mod: control at 44e10620 {
>  				compatible = "ti,am335x-usb-ctrl-module";
>  				reg = <0x44e10620 0x10
>  					0x44e10648 0x4>;
>  				reg-names = "phy_ctrl", "wakeup";
> -				status = "disabled";
>  			};
>  
>  			usb0_phy: usb-phy at 47401300 {
>  				compatible = "ti,am335x-usb-phy";
>  				reg = <0x47401300 0x100>;
>  				reg-names = "phy";
> -				status = "disabled";
>  				ti,ctrl_mod = <&usb_ctrl_mod>;
>  				#phy-cells = <0>;
>  			};
>  
>  			usb0: usb at 47401000 {
>  				compatible = "ti,musb-am33xx";
> -				status = "disabled";
>  				reg = <0x47401400 0x400
>  					0x47401000 0x200>;
>  				reg-names = "mc", "control";
> @@ -443,14 +439,12 @@
>  				compatible = "ti,am335x-usb-phy";
>  				reg = <0x47401b00 0x100>;
>  				reg-names = "phy";
> -				status = "disabled";
>  				ti,ctrl_mod = <&usb_ctrl_mod>;
>  				#phy-cells = <0>;
>  			};
>  
>  			usb1: usb at 47401800 {
>  				compatible = "ti,musb-am33xx";
> -				status = "disabled";
>  				reg = <0x47401c00 0x400
>  					0x47401800 0x200>;
>  				reg-names = "mc", "control";

-- 
Harald

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-62  Fax: +49-8142-66989-80   Email: hws at denx.de