[PATCH 1/1] arm: socfpga: Migrate CONFIG_HPS namespace to HPS

Tom Rini trini at konsulko.com
Tue Aug 10 22:57:27 CEST 2021


On Tue, Aug 10, 2021 at 10:53:02PM +0200, Marek Vasut wrote:
> On 8/10/21 10:47 PM, Tom Rini wrote:
> > On Tue, Aug 10, 2021 at 10:11:08PM +0200, Marek Vasut wrote:
> > > On 8/10/21 10:05 PM, Tom Rini wrote:
> > > > None of the CONFIG_HPS namespace options are changed via the board
> > > > config.h file, nor does it make sense to move them to Kconfig.  Rename
> > > > these options to the HPS namespace instead.
> > > > 
> > > > Cc: Marek Vasut <marex at denx.de>
> > > > Cc: Simon Goldschmidt <simon.k.r.goldschmidt at gmail.com>
> > > > Cc: Tien Fong Chee <tien.fong.chee at intel.com>
> > > > Signed-off-by: Tom Rini <trini at konsulko.com>
> > > > ---
> > > > Note, this patch is complete as the changes to the regex qts-filter.sh
> > > > are such a long line that git send-email fails.  This patch was
> > > > generated by:
> > > > $ git grep -l CONFIG_HPS_ | xargs sed -i -e 's/CONFIG_HPS_/HPS_/g'
> > > > and I will re-run that before applying.
> > > 
> > > The problem is, it is the altera tools which generate all those CONFIG_*
> > > symbols which are processed by the qts-filter.sh and placed into those qts/
> > > board directories, so this patch breaks all that. You'd have to fix the
> > > qts-filter to scrub the CONFIG_ prefixes first.
> > 
> > Or rather, ugh, are there out of tree tools we need to deal with here?
> > Perhaps someone with the tools could pick up and v2 something tested if
> > so as it'll probably be a bit tricky getting it all right.
> 
> See doc/README.socfpga . The out of tree tools generate board/bitstream
> specific input header files which you plug into the qts-filter.sh script ,
> those files contain the CONFIG_* macros and those files get converted by the
> qts-filter.sh script into the output header files in board/*/qts/*.h . The
> output header files are what is used by U-Boot then.

So doc/README.socfpga needs to be updated to rST as well, when someone
that can run the tools and test the scripts work as expected and don't
use the CONFIG_HPS namespace.  Thanks for explaining a bit more.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210810/57ab1184/attachment.sig>


More information about the U-Boot mailing list