[PATCH 4/4] tools: kwbimage: Use IBR_HDR_* constants instead of raw numbers

Stefan Roese sr at denx.de
Wed Aug 11 16:19:46 CEST 2021


On 11.08.21 10:14, Pali Rohár wrote:
> There are already IBR_HDR_* constants for these numbers, so use them.
> 
> Signed-off-by: Pali Rohár <pali at kernel.org>

Reviewed-by: Stefan Roese <sr at denx.de>

Thanks,
Stefan

> ---
>   tools/kwbimage.c | 22 +++++++++++-----------
>   1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/tools/kwbimage.c b/tools/kwbimage.c
> index 5ac34ac5e9c8..c1269fb6633a 100644
> --- a/tools/kwbimage.c
> +++ b/tools/kwbimage.c
> @@ -59,13 +59,13 @@ struct hash_v1 {
>   };
>   
>   struct boot_mode boot_modes[] = {
> -	{ 0x4D, "i2c"  },
> -	{ 0x5A, "spi"  },
> -	{ 0x8B, "nand" },
> -	{ 0x78, "sata" },
> -	{ 0x9C, "pex"  },
> -	{ 0x69, "uart" },
> -	{ 0xAE, "sdio" },
> +	{ IBR_HDR_I2C_ID, "i2c"  },
> +	{ IBR_HDR_SPI_ID, "spi"  },
> +	{ IBR_HDR_NAND_ID, "nand" },
> +	{ IBR_HDR_SATA_ID, "sata" },
> +	{ IBR_HDR_PEX_ID, "pex"  },
> +	{ IBR_HDR_UART_ID, "uart" },
> +	{ IBR_HDR_SDIO_ID, "sdio" },
>   	{},
>   };
>   
> @@ -75,10 +75,10 @@ struct nand_ecc_mode {
>   };
>   
>   struct nand_ecc_mode nand_ecc_modes[] = {
> -	{ 0x00, "default" },
> -	{ 0x01, "hamming" },
> -	{ 0x02, "rs" },
> -	{ 0x03, "disabled" },
> +	{ IBR_HDR_ECC_DEFAULT, "default" },
> +	{ IBR_HDR_ECC_FORCED_HAMMING, "hamming" },
> +	{ IBR_HDR_ECC_FORCED_RS, "rs" },
> +	{ IBR_HDR_ECC_DISABLED, "disabled" },
>   	{},
>   };
>   
> 


Viele Grüße,
Stefan

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de


More information about the U-Boot mailing list