[PATCH v5 09/12] watchdog: wdt-uclass.c: handle all DM watchdogs in watchdog_reset()
Wolfgang Denk
wd at denx.de
Thu Aug 12 08:50:52 CEST 2021
Dear Rasmus,
In message <20210811124800.2593226-10-rasmus.villemoes at prevas.dk> you wrote:
>
> + ret = uclass_get(UCLASS_WDT, &uc);
> + if (ret) {
> + log_debug("Error getting UCLASS_WDT: %d\n", ret);
> + return 0;
> + }
Here the error goes silent, so we should fix the callers to report
it.
> + uclass_foreach_dev(dev, uc) {
> + ret = device_probe(dev);
> + if (ret) {
> + log_debug("Error probing %s: %d\n", dev->name, ret);
> + continue;
> }
Here the situation is different. The probing error is never
reported anywhere. Is it really a normal condition that a
device_probe() fails here?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Here is an Appalachian version of management's answer to those who
are concerned with the fate of the project: "Don't worry about the
mule. Just load the wagon." - Mike Dennison's hillbilly uncle
More information about the U-Boot
mailing list