[PATCH] cmd: boot: Update reset usage message

Michal Simek michal.simek at xilinx.com
Fri Aug 13 08:30:17 CEST 2021



On 8/13/21 8:11 AM, Wolfgang Denk wrote:
> Dear Michal,
> 
> In message <82e0d7efdbd9f8c62f46c7e1a8913ffa52de5a1e.1628676265.git.michal.simek at xilinx.com> you wrote:
>> The commit 573a3811edc8 ("sysreset: psci: support system reset in a generic
>> way with PSCI") has added support for warm reset via PSCI but this hasn't
>> been reflected in usage message and user has to look at the code how to run
>> it. That's why update usage text to make this clear.
>>
>> Here is full help with updated usage:
>> ZynqMP> help reset
>> reset - Perform RESET of the CPU
>>
>> Usage:
>> reset - cold boot without level specifier
>> reset -w - warm reset if implemented
> 
> In case of the hard (cold) reset - is it really only a reset of the
> CPU, or of the whole board hardware?

If you look at sysreset headers you will find these levels
 11         SYSRESET_WARM,  /* Reset CPU, keep GPIOs active */
 12         SYSRESET_COLD,  /* Reset CPU and GPIOs */
 13         SYSRESET_POWER, /* Reset PMIC (remove and restore power) */
 14         SYSRESET_POWER_OFF,     /* Turn off power */

When you call reset sysreset uclass is calling sysreset_walk which is
request to drivers with type passed.
I see we have mixed drivers which deals with levels and especially in
gpio case it is question how you connect it.
I develop this for microblaze where gpio is connected reset logic which
is normally only for CPU and subsystem.
But in general you can connect whatever you want. It means it doesn't
need to be only cpu which is reset.
Do you want me to update that line and remove CPU from it?

Thanks,
Michal


More information about the U-Boot mailing list