[PATCH v3 2/3] arm: mvebu: mvebu_armada-37xx: Define the loadaddr environment variable
Pali Rohár
pali at kernel.org
Fri Aug 13 10:08:46 CEST 2021
On Friday 13 August 2021 01:39:37 Luka Kovacic wrote:
> Add the loadaddr U-Boot environment variable, as this is available in
> the stock Marvell U-Boot by default on Marvell Armada A37XX platforms.
Hello Luka! Why is this change needed? Reason that it is in historic
vendor U-Boot does not mean that it has to be also in new mainline
version.
I have already wrote some reasons in previous review thread:
https://lore.kernel.org/u-boot/20210301150505.3iajeeufi7ahsnk3@pali/
I think this change was needed when CONFIG_SYS_LOAD_ADDR was set to
incorrect value, which is already fixed in mainline U-Boot.
> Signed-off-by: Luka Kovacic <luka.kovacic at sartura.hr>
> Cc: Luka Perkov <luka.perkov at sartura.hr>
> Cc: Robert Marko <robert.marko at sartura.hr>
> ---
> include/configs/mvebu_armada-37xx.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/configs/mvebu_armada-37xx.h b/include/configs/mvebu_armada-37xx.h
> index 8e8bcfa018..6901680e32 100644
> --- a/include/configs/mvebu_armada-37xx.h
> +++ b/include/configs/mvebu_armada-37xx.h
> @@ -110,6 +110,7 @@
>
> /* fdt_addr and kernel_addr are needed for existing distribution boot scripts */
> #define CONFIG_EXTRA_ENV_SETTINGS \
> + "loadaddr=0x6000000\0" \
> "scriptaddr=0x6d00000\0" \
> "pxefile_addr_r=0x6e00000\0" \
> "fdt_addr=0x6f00000\0" \
> --
> 2.31.1
>
More information about the U-Boot
mailing list