[PATCH] configs: Layerscape: Remove the 'fdt_addr' env

Priyanka Jain (OSS) priyanka.jain at oss.nxp.com
Wed Aug 18 12:33:07 CEST 2021



>-----Original Message-----
>From: U-Boot <u-boot-bounces at lists.denx.de> On Behalf Of Zhiqiang Hou
>Sent: Thursday, August 12, 2021 12:59 PM
>To: u-boot at lists.denx.de; Priyanka Jain <priyanka.jain at nxp.com>
>Cc: ykaukab at suse.de; festevam at gmail.com; trini at konsulko.com; Z.Q. Hou
><zhiqiang.hou at nxp.com>
>Subject: [PATCH] configs: Layerscape: Remove the 'fdt_addr' env
>
>From: Hou Zhiqiang <Zhiqiang.Hou at nxp.com>
>
>On Layerscape platforms, the DTB is loaded from boot filesystem, per the
>fdt_addr description in doc/README.distro, it must be removed.
>

Below description is unrelated .
It is due to some other issue. Kindly remove it from this patch.


>And on many platforms, like ls1046a, ls1088a, ls2088a and lx216xa, the 'fdt_addr'
>pointed address is not accessible.
>And with the current EFI boot process, since the EFI_LOADER and
>CMD_BOOTEFI_BOOTMGR are enabled by default, if the EFI boot components
>are not deployed in the boot filesystem, it will try to get DTB at address 'fdt_addr'
>and then result in "SError" or "Synchronous Abort":
>
>Error log on ls1046ardb:
>	=> run distro_bootcmd
>	switch to partitions #0, OK
>	mmc0 is current device
>	Scanning mmc 0:1...
>	libfdt fdt_check_header(): FDT_ERR_BADMAGIC
>	Scanning disk esdhc at 1560000.blk...
>	Found 5 disks
>	No EFI system partition
>	"Error" handler, esr 0xbf000000
>	elr: 00000000820704f4 lr : 00000000820080d4 (reloc)
>	elr: 00000000fbd914f4 lr : 00000000fbd290d4
>	x0 : 0000000064f00000 x1 : 00000000edfe0dd0
>	x2 : 0000000000000000 x3 : 0000000000000000
>	x4 : 00000000fbc2ee1a x5 : 000000000000000f
>	x6 : 0000000000000000 x7 : 0000000000000008
>	x8 : 0000000000000010 x9 : 0000000000000008
>	x10: 0000000000000044 x11: 00000008ffff0220
>	x12: 00000000fbdaa748 x13: 00000000fbda70f8
>	x14: 00000000fbd21d20 x15: 00000000fbc194e8
>	x16: 00000000fbd70fc8 x17: 0000000000000000
>	x18: 00000000fbc1cdb0 x19: 00000000fbd21bf0
>	x20: 0000000064f00000 x21: 00000000fbda6fb8
>	x22: 0000000000000018 x23: 0000000000000018
>	x24: 00000000fbde6344 x25: 0000000000000000
>	x26: 0000000000000000 x27: 0000000000000000
>	x28: 00000000fbc53660 x29: 00000000fbc19220
>
>	Code: 7a419060 1a9f3000 a8c17bfd d65f03c0 (12800100)
>
>	Resetting CPU ...
>
>Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou at nxp.com>
>---
> include/configs/ls1012a2g5rdb.h  | 1 -
> include/configs/ls1012afrdm.h    | 2 +-
> include/configs/ls1012afrwy.h    | 1 -
> include/configs/ls1012aqds.h     | 1 -
> include/configs/ls1012ardb.h     | 1 -
> include/configs/ls1021atsn.h     | 3 +--
> include/configs/ls1021atwr.h     | 4 +---
> include/configs/ls1028aqds.h     | 3 +--
> include/configs/ls1028ardb.h     | 3 +--
> include/configs/ls1043a_common.h | 1 -
> include/configs/ls1046a_common.h | 1 -
> include/configs/ls1088ardb.h     | 2 --
> include/configs/ls2080ardb.h     | 2 --
> include/configs/lx2160a_common.h | 1 -
> 14 files changed, 5 insertions(+), 21 deletions(-)
>
>diff --git a/include/configs/ls1012a2g5rdb.h b/include/configs/ls1012a2g5rdb.h
>index 44f9da7306..d9ff011bac 100644
>--- a/include/configs/ls1012a2g5rdb.h
>+++ b/include/configs/ls1012a2g5rdb.h
>@@ -29,7 +29,6 @@
> #define CONFIG_EXTRA_ENV_SETTINGS		\
> 	"verify=no\0"				\
> 	"initrd_high=0xffffffffffffffff\0"	\
>-	"fdt_addr=0x00f00000\0"			\

Getting below checkpatch error:
ERROR: fdt or initrd relocation disabled at boot time
#76: FILE: include/configs/ls1012a2g5rdb.h:31:
        "initrd_high=0xffffffffffffffff\0"      \

Kindly remove unused 'initrd_high' variable as well in this patch in all header files.

Regards
Priyanka


More information about the U-Boot mailing list