[PATCH 05/13] siemens: Move CONFIG_SYS_I2C_EEPROM_ADDR usage out of CONFIG namespace

[Tom Rini]

On Wed, Aug 18, 2021 at 11:02:28AM +0200, Anatolij Gustschin wrote:
> On Tue, 17 Aug 2021 17:59:40 -0400
> Tom Rini trini at konsulko.com wrote:
> 
> > The instances of CONFIG_SYS_I2C_EEPROM_ADDR on these platforms doesn't
> > match up with the rest of the EERPOM related defines in U-Boot.  Move
> > these out of the CONFIG namespace rather than make complex Kconfig
> > logic.
> > 
> > Cc: Samuel Egli <samuel.egli at siemens.com>
> > Cc: Anatolij Gustschin <agust at denx.de>
> > Cc: Heiko Schocher <hs at denx.de>
> > Signed-off-by: Tom Rini <trini at konsulko.com>
> 
> Reviewed-by: Anatolij Gustschin <agust at denx.de>
> 
> But probably some more cleanup in other board config headers needed,
> see comment below.
> 
> ...
> > diff --git a/include/configs/draco.h b/include/configs/draco.h
> > index 396eb7ded500..7c1f071d99ec 100644
> > --- a/include/configs/draco.h
> > +++ b/include/configs/draco.h
> > @@ -32,10 +32,6 @@
> >  /* I2C Configuration */
> >  #define CONFIG_SYS_I2C_SPEED		100000
> >  
> > -#define CONFIG_SYS_I2C_EEPROM_ADDR              0x50
> > -#define EEPROM_ADDR_DDR3 0x90
> > -#define EEPROM_ADDR_CHIP 0x120
> 
> these defines are also in
> 
>  include/configs/etamin.h
>  include/configs/rastaban.h
>  include/configs/thuban.h

Yes, it would be good for the board maintainers to follow up with more
clean-up and migrate some siemens-specific symbols to Kconfig.  I'm
trying to not get too far off track and focus on just getting symbols in
to Kconfig or out of CONFIG namespace right now.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210818/8dd74771/attachment.sig>