[PATCH v6 10/12] watchdog: add gpio watchdog driver

Tom Rini trini at konsulko.com
Thu Aug 19 15:08:06 CEST 2021


On Thu, Aug 19, 2021 at 03:03:46PM +0200, Wolfgang Denk wrote:
> Dear Tom,
> 
> In message <20210819123540.GV858 at bill-the-cat> you wrote:
> > 
> > Since I literally just sent this in another email you couldn't have seen
> > yet, I'll repeat it here.  Feel free to follow up to this with a series
> > to further update things, Wolfgang.
> 
> So we have now a policy to wave through code, and ask others to
> clean it up later?  That's ... sad.

No, we continue to have the policy of expecting reviewers to follow the
whole discussion and relevant subsystems.  Changing _every_ caller of
dev_get_priv to check for NULL and then, what? is clearly not the right
answer.  If you think you see a problem here please go audit the DM code
itself more and propose some changes.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210819/934af4c2/attachment.sig>


More information about the U-Boot mailing list