[PATCH v1 1/7] imx: mkimage_fit_atf: fix legacy image generation

[Marcel Ziswiler]

Hi Andrey

Long time no see (;-p).

On Sun, 2021-08-22 at 10:07 +0000, ZHIZHIKIN Andrey wrote:
> Hello Marcel,
> 
> > -----Original Message-----
> > From: U-Boot <u-boot-bounces at lists.denx.de> On Behalf Of Marcel Ziswiler
> > Sent: Friday, August 20, 2021 10:52 PM
> > To: u-boot at lists.denx.de
> > Cc: Heiko Thiery <heiko.thiery at gmail.com>; Stefano Babic <sbabic at denx.de>;
> > Fabio Estevam <festevam at gmail.com>; Frieder Schrempf
> > <frieder.schrempf at kontron.de>; Marcel Ziswiler
> > <marcel.ziswiler at toradex.com>; NXP i.MX U-Boot Team <uboot-
> > imx at nxp.com>; Peng Fan <peng.fan at nxp.com>
> > Subject: [PATCH v1 1/7] imx: mkimage_fit_atf: fix legacy image generation
> > 
> > 
> > From: Marcel Ziswiler <marcel.ziswiler at toradex.com>
> > 
> > While most boards meanwhile migrated to using binman a few like the verdin-
> > imx8mm are still using the legacy image generation.
> > Unfortunately, the legacy image generation is currently broken which is especially
> > bad for any kind of bisection attempts.
> > Anyway, this fixes it even though we will also migrate to using binman shortly.
> 
> This change has been already proposed in [1],

Well, what I do not get is how one can move forward and leave all kinds of stuff just broken. Fact is, that the
legacy image creation has been and still is plain simply broken!

> but the discussion went into the direction of monolithic "flash.bin" rather than a migration to use binman.

Well, those two do actually not rule each other out. Remember, later in this patch set I am migrating to using
binman which I instruct to generate a monolithic "flash.bin" again.

> I guess if this change is really needed due to the fact that the migration of some boards is really difficult
> - the original patch can be taken.

What I found extremely problematic is, as mentioned initially, stuff is currently broken which makes e.g.
bisecting other issues extremely cumbersome. But in theory, as I propose now to migrate anyway, we could just
not care and leave it broken for anybody else. I just feel this is not really too nice of a gesture!

> However, I've commented out in that thread that there is a warning regarding the usage of scripts and
> migration notice, so maybe it does make sense to spend extra effort to migrate away from this script at all?

Yes, of course, it is the goal to migrate. I just don't get how in IT new stuff gets introduced all the time
with leaving past things broken. Just a little bit annoying...

> > Fixes: commit cb9faa6f98ae
> >  ("tools: Use a single target-independent config to enable OpenSSL")
> ...
> 
> Link: [1]: https://lore.kernel.org/u-boot/20210505120053.9466-1-oliver.graute@kococonnector.com/
> 
> Regards,
> Andrey

Cheers

Marcel