[PATCH v2 1/1] fastboot: fb_getvar: Add getvar_logical_blocksize for NXP mfgtool

Angus Ainslie angus at akkea.ca
Wed Dec 29 16:15:43 CET 2021

Hi Oleh,

On 2021-12-29 07:07, Oleh Kravchenko wrote:
> Hello Angus,
> 29.12.21 15:35, Angus Ainslie пише:
>> The version of uuu that we are using requires the block-size for the 
>> sparse upload
>> https://source.puri.sm/Librem5/mfgtools/-/blob/pureos/amber/libuuu/fastboot.cpp#L501
> This version is outdated (2 years old).
> Maybe it is time to upgrade to the latest one?

That was one of my suggested solutions but it would still leave older 
uuu implementations out there that won't work with mainline u-boot.

>> It looks like the upstream version will default to 4096 if the 
>> block-size is not provided
>> https://github.com/NXPmicro/mfgtools/blob/5397913ad97db422c1d70f314dedff4cb7d976b9/libuuu/fastboot.cpp#L642
>> Instead of making assumptions about the block size wouldn't it be 
>> better to provide one if requested ?
> +1 if it works faster ^_^

I haven't done any speed tests so I can't really comment about the 

>> We could also remove that being a required parameter from the uuu that 
>> we are using but that still leaves versions out there that won't work 
>> with a mainline u-boot.
> Why does mainline use fixed block size 4096?

That's a fall back if the fastboot implementation doesn't provide a 
block-size , probably so that it can work with mainline u-boot.

> Excuse me for direct questions I'm just curious.

NP that's what review is for.


More information about the U-Boot mailing list