[PATCH v2 1/8] spl: Drop duplicate 'Jumping to U-Boot' message

Pratyush Yadav p.yadav at ti.com
Mon Feb 1 18:46:16 CET 2021


On 23/01/21 10:36AM, Simon Glass wrote:
> This is printed twice but we only need one message, since there is very
> little processing in between them. Drop the first one.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
> 
> (no changes since v1)
> 
>  common/spl/spl.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/common/spl/spl.c b/common/spl/spl.c
> index 12b00e2a407..7fe0812799f 100644
> --- a/common/spl/spl.c
> +++ b/common/spl/spl.c
> @@ -693,7 +693,6 @@ void board_init_r(gd_t *dummy1, ulong dummy2)
>  #endif
>  	switch (spl_image.os) {
>  	case IH_OS_U_BOOT:
> -		debug("Jumping to U-Boot\n");

IMO it would make more sense to drop the "jumping to u-boot" part from 
the "loaded - jumping to u-boot" message below. This way you avoid 
duplication in case of ATF, OPTEE, OpenSBI, etc. This would also avoid 
saying "jumping to u-boot" right after saying "jumping to linux".

>  		break;
>  #if CONFIG_IS_ENABLED(ATF)
>  	case IH_OS_ARM_TRUSTED_FIRMWARE:
> -- 
> 2.30.0.280.ga3ce27912f-goog
> 

-- 
Regards,
Pratyush Yadav
Texas Instruments Inc.


More information about the U-Boot mailing list