[PATCH v3] mmc: mmc_spi: Print verbose debug output when crc16 check fails

Bin Meng bmeng.cn at gmail.com
Tue Feb 2 03:32:48 CET 2021


Add some verbose debug output when crc16 check fails.

Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
Reviewed-by: Jaehoon Chung <jh80.chung at samsung.com>

---

Changes in v3:
- use expected/got instead of expect/get

Changes in v2:
- do the crc_ok assignment at the the same line where it's defined

 drivers/mmc/mmc_spi.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/mmc_spi.c b/drivers/mmc/mmc_spi.c
index 46800bb..23b9073 100644
--- a/drivers/mmc/mmc_spi.c
+++ b/drivers/mmc/mmc_spi.c
@@ -181,8 +181,10 @@ static int mmc_spi_readdata(struct udevice *dev,
 			if (ret)
 				return ret;
 #ifdef CONFIG_MMC_SPI_CRC_ON
-			if (be16_to_cpu(crc16_ccitt(0, buf, bsize)) != crc) {
-				debug("%s: data crc error\n", __func__);
+			u16 crc_ok = be16_to_cpu(crc16_ccitt(0, buf, bsize));
+			if (crc_ok != crc) {
+				debug("%s: data crc error, expected %04x got %04x\n",
+				      __func__, crc_ok, crc);
 				r1 = R1_SPI_COM_CRC;
 				break;
 			}
-- 
2.7.4



More information about the U-Boot mailing list