Subject:[PATCH v2 4/4] board/km: add support for seli8 design based on nxp ls102x

[Tom Rini]

On Wed, Feb 03, 2021 at 08:15:49AM +0000, Priyanka Jain wrote:
> 
> 
> >-----Original Message-----
> >From: U-Boot <u-boot-bounces at lists.denx.de> On Behalf Of Aleksandar
> >Gerasimovski
> >Sent: Tuesday, February 2, 2021 2:37 PM
> >To: Priyanka Jain (OSS) <priyanka.jain at oss.nxp.com>; u-boot at lists.denx.de
> >Cc: Valentin Longchamp <valentin.longchamp at hitachi-powergrids.com>; Holger
> >Brunck <holger.brunck at hitachi-powergrids.com>; Rainer Boschung
> ><rainer.boschung at hitachi-powergrids.com>; Matteo Ghidoni
> ><matteo.ghidoni at hitachi-powergrids.com>
> >Subject: RE: Subject:[PATCH v2 4/4] board/km: add support for seli8 design based
> >on nxp ls102x
> >
> >
> >-----Original Message-----
> >From: Priyanka Jain (OSS) <priyanka.jain at oss.nxp.com>
> >Sent: Dienstag, 2. Februar 2021 07:33
> >To: Aleksandar Gerasimovski <aleksandar.gerasimovski at hitachi-
> >powergrids.com>; Priyanka Jain (OSS) <priyanka.jain at oss.nxp.com>; u-
> >boot at lists.denx.de
> >Cc: Valentin Longchamp <valentin.longchamp at hitachi-powergrids.com>; Holger
> >Brunck <holger.brunck at hitachi-powergrids.com>; Rainer Boschung
> ><rainer.boschung at hitachi-powergrids.com>; Matteo Ghidoni
> ><matteo.ghidoni at hitachi-powergrids.com>
> >Subject: RE: Subject: [PATCH v2 4/4] board/km: add support for seli8 design based
> >on nxp ls102x
> >
> >CAUTION: This email originated from outside of the organization. Do not click
> >links or open attachments unless you recognize the sender and know the content
> >is safe.
> >
> >
> >>-----Original Message-----
> >>From: Aleksandar Gerasimovski <aleksandar.gerasimovski at hitachi-
> >>powergrids.com>
> >>Sent: Tuesday, January 19, 2021 4:11 PM
> >>To: Priyanka Jain (OSS) <priyanka.jain at oss.nxp.com>;
> >>u-boot at lists.denx.de
> >>Cc: Valentin Longchamp <valentin.longchamp at hitachi-powergrids.com>;
> >>Holger Brunck <holger.brunck at hitachi-powergrids.com>; Rainer Boschung
> >><rainer.boschung at hitachi-powergrids.com>; Matteo Ghidoni
> >><matteo.ghidoni at hitachi-powergrids.com>
> >>Subject: Subject: [PATCH v2 4/4] board/km: add support for seli8 design
> >>based on nxp ls102x
> >>
> >>The SELI8 design is a new tdm service unit card for Hitachi-Powergrids
> >>XMC and FOX product lines.
> >>
> >>It is based on NXP LS1021 SoC and it provides following interfaces:
> >> - IFC interface for NOR, NAND and external FPGA's
> >> - 1 x RGMII ETH for debug purposes
> >> - 2 x SGMII ETH for management communication via back-plane
> >> - 1 x uQE HDLC for management communication via back-plane
> >> - 1 x I2C for peripheral devices
> >> - 1 x SPI for peripheral devices
> >> - 1 x UART for debug logging
> >>
> >>It is foreseen that the design will be later re-used for another XMC
> >>and FOX service cards with similar SoC requirements.
> >>
> >>Signed-off-by: Rainer Boschung <rainer.boschung at hitachi-powergrids.com>
> >>Signed-off-by: Matteo Ghidoni <matteo.ghidoni at hitachi-powergrids.com>
> >>Signed-off-by: Aleksandar Gerasimovski
> >><aleksandar.gerasimovski at hitachi- powergrids.com>
> >>---
> ><snip>
> >Kindly fix below checkpatch errors /warnings
> >WARNING: 'AYSNC' may be misspelled - perhaps 'ASYNC'?
> >#799: FILE: include/configs/km/pg-wcom-ls102xa.h:64:
> >+                                       CSOR_NOR_NOR_MODE_AYSNC_NOR | \
> >
> >ERROR: All commands are managed by Kconfig
> >#953: FILE: include/configs/km/pg-wcom-ls102xa.h:218:
> >+#define CONFIG_CMDLINE_TAG
> >
> >total: 1 errors, 2 warnings, 0 checks, 964 lines checked
> >
> >Regards
> >Priyanka
> >
> >Hi Priyanka,
> >
> >CSOR_NOR_NOR_MODE_AYSNC_NOR is named like in mainline (nxp) see
> >include/fsl_ifc.h If you asking me to change that than it belongs to a separate
> >patch, not this topic.
> >
> OK this warning can be ignored
> 
> >CONFIG_CMDLINE_TAG is a whitelisted on mainline, there is no Kconfig for that.
> >
> 
> Tom,
> 
> How to handle this checkpatch error?
> CONFIG_CMDLINE_TAG is a whitelisted in mainline, but checkpatch is throwing error.
> Can I go ahead and accept this patch ?

There's two parts to it.  One part, checkpatch regex is wrong and
shouldn't trigger on that, since it's not an actual command.  Second
part, uh, does passing ATAGs make sense on that platform?  Is there some
unfortunate and needing to be fixed logic in U-Boot that requires
CMDLINE_TAG (and the few others) to be enabled for device tree to be
passed or something?

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210203/d0569e4b/attachment.sig>