[PATCH 02/13] arm: imx: Remove unused CONFIG_xxx_TAG support

Fabio Estevam festevam at gmail.com
Thu Feb 4 20:20:39 CET 2021


On Thu, Feb 4, 2021 at 1:44 PM Tom Rini <trini at konsulko.com> wrote:

> So, I see 3 options here:
> 1. In arch/arm/mach-imx/mx7/soc.c and board/warp7/warp7.c switch from
> CONFIG_SERIAL_TAG to CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG (and migrate
> from warp7.h to defconfig to enable).  This won't break existing users /
> documentation where the device showing up by serial number WITH "WaRP7"
> in the name is expected.  The serial ATAG is defined regardless of
> CONFIG_SERIAL_TAG so it'll still be available, and we're not likely to
> remove ATAG support globally for some time yet.
> 2. Adjust arch/arm/mach-imx/mx7/soc.c to follow the common practice of
> arch_misc_init() calling the function to read the fuse(s) and set
> "serial#" to match that, without other identifiers.  This would enable
> the feature for all imx7 boards but change the value on
> new/re-initialized WaRP7 boards and probably break documentation.
> 3. Do nothing.  WaRP7 works as-is, using CONFIG_SERIAL_TAG is something
> I think was a bit too clever, but I can also see why it was used since
> after-all it's using the serial tag record, etc.
>
> Option 3 is my least preferred choice, but, if the relevant custodians
> like that the most, that's fine with me.

Option 1 is the less intrusive one IMHO, so I would prefer it.

Thanks


More information about the U-Boot mailing list