[PATCH] gpio-uclass: fix gpio flags save condition

Köry Maincent kory.maincent at bootlin.com
Fri Feb 5 15:48:52 CET 2021


Hi Simon,

On Thu, 4 Feb 2021 19:45:22 -0700
Simon Glass <sjg at chromium.org> wrote:


> Thank you for that. I think that is because dm_gpio_set_dir_flags()
> does not clear the flags first. But we now do actually update
> desc->flags, where as before it was just supposed to happen. So I
> think this function needs to update to clear the direction flags, then
> add in the ones passed.
> 
> I have pushed this to u-boot-dm/gpio-working if you can test it again.

I have tested your v4 series of patches and all works well for my onewire on
gpio.
Thanks for your update.

Regards,
Köry


More information about the U-Boot mailing list