[RESEND PATCH 04/16] usb: musb: Always clear the data toggle bit when configuring ep

[Lukasz Majewski]

On Fri,  5 Feb 2021 20:12:00 +0100
Pali Rohár <pali at kernel.org> wrote:

> Without this patch it was done only when U-Boot was compiled with
> MUSB Host Controller. But it is needed also for MUSB Device
> Controller, otherwise Device Controller does not work.
> 

Reviewed-by: Lukasz Majewski <lukma at denx.de>

> Signed-off-by: Pali Rohár <pali at kernel.org>
> ---
>  drivers/usb/musb/musb_core.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/usb/musb/musb_core.c
> b/drivers/usb/musb/musb_core.c index 147b2eb929..cc6dc3839d 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -81,10 +81,8 @@ void musb_configure_ep(const struct musb_epinfo
> *epinfo, u8 cnt) config_fifo(tx, idx, fifoaddr);
>  
>  			csr = readw(&musbr->txcsr);
> -#if defined(CONFIG_USB_MUSB_HCD)
>  			/* clear the data toggle bit */
>  			writew(csr | MUSB_TXCSR_CLRDATATOG,
> &musbr->txcsr); -#endif
>  			/* Flush fifo if required */
>  			if (csr & MUSB_TXCSR_TXPKTRDY)
>  				writew(csr | MUSB_TXCSR_FLUSHFIFO,
> @@ -94,10 +92,8 @@ void musb_configure_ep(const struct musb_epinfo
> *epinfo, u8 cnt) config_fifo(rx, idx, fifoaddr);
>  
>  			csr = readw(&musbr->rxcsr);
> -#if defined(CONFIG_USB_MUSB_HCD)
>  			/* clear the data toggle bit */
>  			writew(csr | MUSB_RXCSR_CLRDATATOG,
> &musbr->rxcsr); -#endif
>  			/* Flush fifo if required */
>  			if (csr & MUSB_RXCSR_RXPKTRDY)
>  				writew(csr | MUSB_RXCSR_FLUSHFIFO,




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210206/f1c2c9e6/attachment.sig>