[PATCH 01/26] Revert "pci: pci-uclass: Dynamically allocate the PCI regions"
Simon Glass
sjg at chromium.org
Sun Feb 7 16:33:50 CET 2021
Hi Bin,
On Sun, 7 Feb 2021 at 08:11, Bin Meng <bmeng.cn at gmail.com> wrote:
>
> This reverts commit e002474158d1054a7a2ff9a66149384c639ff242.
>
> Commit e002474158d1 ("pci: pci-uclass: Dynamically allocate the PCI regions")
> changes 'struct pci_controller'.regions from pre-allocated array of
> regions to dynamically allocated, which unfortunately broken lots of
> boards that still use the non-DM PCI driver.
>
> We may update every non-DM PCI board codes to do the dynamical
> allocation of PCI regions but that's a lot of work (e.g.: almost
> all Freescale PowerPC boards are broken now and need to be fixed).
> Let's do the easy way.
No one has noticed since July, apparently. I think it would be better
to disable PCI on these boards, until either someone migrates them or
they are removed. The PCI deadline was about 18 months ago.
Tom, do you know the situation here?
>
> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
> ---
>
> drivers/pci/pci-uclass.c | 14 ++++++--------
> include/pci.h | 4 +++-
> 2 files changed, 9 insertions(+), 9 deletions(-)
Regards,
Simon
More information about the U-Boot
mailing list