[PATCH u-boot-marvell] mmc: mv_sdhci: call mmc_of_parse()

Stefan Roese sr at denx.de
Mon Feb 8 12:40:34 CET 2021


On 04.02.21 17:38, Marek Behún wrote:
> On Thu, 4 Feb 2021 07:18:23 +0900
> Jaehoon Chung <jh80.chung at samsung.com> wrote:
> 
>>> Commit da18c62b6e6a causes the regression. The Fixes tag, as I
>>> understand, should link to commit with which the regression first
>>> occured, so that if someone wanted to backport my patch to previous
>>> version of U-Boot, they would know that they only have to do it if
>>> their repository contains that commit.
>>
>> Well, i don't think so. This patch is not a bug fix patch about
>> commit da18c62b6e6a. Just mv_sdhci driver didn't use mmc_of_parse()
>> before. (If someone set to MMC_NON_REMOVABLE capabilities in
>> host->cap, it should be working.)
>>
>> Not need to add *Fixes*. Its commit is a generic callback function.
>> And mmc_of_parse() is also generic function to use Driver-model.
> 
> Lets apply Baruch's version. I don't really care if the Fixes tag is
> there or not...

I'll pull in Baruch's patch now.

Thanks,
Stefan


More information about the U-Boot mailing list