[PATCH 4/6] usb: xhci-pci: Move reset logic out of XHCI core

Marek Vasut marex at denx.de
Mon Feb 8 12:43:52 CET 2021


On 2/8/21 6:57 AM, Samuel Holland wrote:
> Resetting an XHCI controller inside xhci_register undoes any register
> setup performed by the platform driver. And at least on the Allwinner
> H6, resetting the XHCI controller also resets the PHY, which prevents
> the controller from working. That means the controller must be taken out
> of reset before initializing the PHY, which must be done before calling
> xhci_register.
> 
> The logic in the XHCI core was added to support the Raspberry Pi 4
> (although this was not mentioned in the commit log!), which uses the
> xhci-pci platform driver. Move the reset logic to the platform driver,
> where it belongs, and where it cannot interfere with other platform
> drivers.

Are there any other XHCI drivers using the XHCI core code which might 
stop resetting correctly due to this patch ?


More information about the U-Boot mailing list