[PATCH 13/13] arm: stm32: Disable ATAGs support

Patrick DELAUNAY patrick.delaunay at foss.st.com
Mon Feb 8 17:34:50 CET 2021


Hi Tom,

On 2/4/21 3:24 AM, Tom Rini wrote:
> These platforms never had to support an ATAGs-based Linux Kernel, so
> remove the options.
>
> Cc: Kamil Lulko <kamil.lulko at gmail.com>
> Cc: Patrick Delaunay <patrick.delaunay at foss.st.com>
> Cc: Patrice Chotard <patrice.chotard at foss.st.com>
> Cc: Vikas Manocha <vikas.manocha at st.com>
> Cc: Marek Vasut <marex at denx.de>
> Signed-off-by: Tom Rini <trini at konsulko.com>
> ---
> I'm assuming, please correct me if I'm wrong.
> ---
>   include/configs/stm32f429-discovery.h  | 5 -----
>   include/configs/stm32f429-evaluation.h | 5 -----
>   include/configs/stm32f469-discovery.h  | 5 -----
>   include/configs/stm32f746-disco.h      | 5 -----
>   include/configs/stm32h743-disco.h      | 5 -----
>   include/configs/stm32h743-eval.h       | 5 -----
>   include/configs/stm32mp1.h             | 5 -----
>   7 files changed, 35 deletions(-)
>

Yes you are right.

It is inherited of the first U-boot porting (before full DM and FDT 
support).


Reviewed-by: Patrick Delaunay <patrick.delaunay at foss.st.com>


For information the initialization parts can be removed in boards 
support (as no more used):

     gd->bd->bi_boot_params = gd->bd->bi_dram[0].start + 0x100;

     in     ./board/st/

     - stm32f429-evaluation/stm32f429-evaluation.c:54:
     - stm32h743-disco/stm32h743-disco.c:55:
     - stm32f429-discovery/stm32f429-discovery.c:60:
     - stm32mp1/stm32mp1.c:644:
     - stm32f746-disco/stm32f746-disco.c:129:
     - stm32f469-discovery/stm32f469-discovery.c:54:
     - stm32h743-eval/stm32h743-eval.c:55:

But I will push a separate patch for this point.


Just one question for other part of generic code which can be removed....

bi_boot_params should be under compilation BOOTM_ENABLE_TAGS flags ?

In include/asm-generic/u-boot.h:70
     struct bd_info {

     ....
         ulong            bi_boot_params;    /* where this board expects 
params */

     ...

     };


and also params global variables, only used in setup_XXX functions ?

     arch/arm/lib/bootm.c:44:
         static struct tag *params;


Regards


Thanks

Patrick




More information about the U-Boot mailing list