[PATCH] efidebug: Introduce bootmgr command

Ilias Apalodimas ilias.apalodimas at linaro.org
Wed Feb 10 12:53:55 CET 2021


Hi Wolfgang,

Thanks for having a look, 

On Wed, Feb 10, 2021 at 12:23:47PM +0100, Wolfgang Denk wrote:
> Dear Ilias,
> 
> In message <20210210105425.356131-1-ilias.apalodimas at linaro.org> you wrote:
> > Up to now we've been adding all the efi related configuration to
> > 'efidebug' command.  The command name feels a bit weird to configure boot
> > manager related commands.  Since the bootmanager is growing and we intend
> > to extend it with features like defining the initrd we want to expose to
> > the kernel, it would make sense to split it on a command of it's own.
> >
> > So let's introduce a new command called bootmgr and move all of the
> > existing Boot manager functionality there.
> 
> As this is EFI specific, I would appreciate to have "efi" in the
> command name, too.
> 
> Maybe all EFi related commands should be collected as "efi <subcommand>"
> like we did it with the "env" commands long ago.

We could, I'll discuss this with Heinrich and see what he thinks.

> 
> For backward compatibility e. g. 'efidebug' could be kept, but the
> new name would be 'efi debug'; likewise, your new command would be
> 'efi bootmgr' [or just 'efi boot' ?]

The efidebug for boot options wasn't introduced that long ago and I don't
think anyone uses it in production.  If someone would want to have it backwards 
compatible, please shout and we'll see what we can do, but I'd strongly prefer 
replacing it overall. If we truly want backwards compatibility though we must keep
efidebug, changing the name to something like 'efi debug' just for the name
similarity wouldn't help much as it would break things regardless.

Heinrich feel free to ignore the followup patch fixing the documentation of
efidebug.  I'll change the name to something we all agree and fold in the doc
changes in v2.

Thanks
/Ilias
> 
> Thanks!
> 
> Wolfgang Denk
> 
> -- 
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> In my experience the best way to get something done  is to give it to
> someone who is busy.               - Terry Pratchett, _Going_Postal_


More information about the U-Boot mailing list