[PATCH 01/26] Revert "pci: pci-uclass: Dynamically allocate the PCI regions"

[Marek Vasut]

On 2/14/21 3:35 PM, Tom Rini wrote:
> On Sun, Feb 14, 2021 at 12:53:29PM +0800, Bin Meng wrote:
>> Hi Tom,
>>
>> On Wed, Feb 10, 2021 at 10:13 PM Tom Rini <trini at konsulko.com> wrote:
>>>
>>> On Wed, Feb 10, 2021 at 08:46:51AM +0800, Bin Meng wrote:
>>>> Hi Simon,
>>>>
>>>> On Sun, Feb 7, 2021 at 11:34 PM Simon Glass <sjg at chromium.org> wrote:
>>>>>
>>>>> Hi Bin,
>>>>>
>>>>> On Sun, 7 Feb 2021 at 08:11, Bin Meng <bmeng.cn at gmail.com> wrote:
>>>>>>
>>>>>> This reverts commit e002474158d1054a7a2ff9a66149384c639ff242.
>>>>>>
>>>>>> Commit e002474158d1 ("pci: pci-uclass: Dynamically allocate the PCI regions")
>>>>>> changes 'struct pci_controller'.regions from pre-allocated array of
>>>>>> regions to dynamically allocated, which unfortunately broken lots of
>>>>>> boards that still use the non-DM PCI driver.
>>>>>>
>>>>>> We may update every non-DM PCI board codes to do the dynamical
>>>>>> allocation of PCI regions but that's a lot of work (e.g.: almost
>>>>>> all Freescale PowerPC boards are broken now and need to be fixed).
>>>>>> Let's do the easy way.
>>>>>
>>>>> No one has noticed since July, apparently. I think it would be better
>>>>> to disable PCI on these boards, until either someone migrates them or
>>>>> they are removed. The PCI deadline was about 18 months ago.
>>>>>
>>>>
>>>> Yep, but I'd like to keep this revert instead of just fixing the
>>>> qemu-ppce500 here, to give people a chance to test their original
>>>> non-DM version of PCI driver before the DM conversion.
>>>>
>>>> Once all boards have converted to DM PCI, we can revert this revert patch again.
>>>>
>>>>> Tom, do you know the situation here?
>>>
>>> So, I made a lack of DM_PCI migration be fatal and got a build done
>>> here:
>>> https://gitlab.denx.de/u-boot/u-boot/-/pipelines/6348
>>>
>>> Of note, MIPS malta fails, so I had to drop that from pytest to complete
>>> the world build.  There's then a handful of ARM boards, another large
>>> chunk of PowerPC, and then a few others such as r7780mp.  SH is the big
>>> what to do here to me, other than PowerPC, as other than r2dplus
>>> everything is missing the main "convert to DM" migration deadline as
>>> well.
>>
>> What should we do for this patch?
>>
>> If the plan is to drop all boards that are not converted to DM PCI in
>> 2021.04, I can drop this revert patch in v2.
> 
> I've posted the patch to drop the SH boards.  Daniel, what about Malta?

Malta should be fixed, since it's mips used in CI.

> I guess maybe the next steps are I need to pull in the already acked
> board removal patches I've posted and then do another posting of "remove
> these boards now" and see what shakes out.

Yeah