[PATCH v4 4/7] sandbox: Add a DSA sandbox driver and unit test

Michael Walle michael at walle.cc
Tue Feb 16 22:33:37 CET 2021


Am 2021-02-16 22:21, schrieb Vladimir Oltean:
> On Tue, Feb 16, 2021 at 04:13:41PM -0500, Tom Rini wrote:
>> On Tue, Feb 16, 2021 at 11:02:25PM +0200, Vladimir Oltean wrote:
>> > Hi Tom,
>> >
>> > On Tue, Feb 16, 2021 at 01:14:57PM -0500, Tom Rini wrote:
>> > > This test does not pass for me.  This can be seen at:
>> > > https://gitlab.denx.de/u-boot/u-boot/-/jobs/223660
>> > >
>> > > Note that I'm still reviewing the rest of the series right now.
>> >
>> > You're right, thanks for letting me know.
>> > I've fixed this in my tree [ by adding two more patches :-/ ], let me
>> > know if you have any other feedback, otherwise I'm going to resend soon.
>> 
>> I'm about to push the rest of the series, so you can rebase on master
>> shortly, thanks!  Or should I hold off as this exposed problems in the
>> rest of your series?
> 
> Sorry, I missed your reply earlier. I just sent out a new version which
> should be sandbox-clean and which also makes the fixed PHY driver
> compatible with live OF, since that's what the problem was, 
> essentially.

If this series is merged, I'd just send a follow up for the kontron sl28
board device tree, which also uses DSA. Originally, this it wasn't
possible to include the patch in this series, because there was still
the base device tree for this board variant pending in u-boot.

So if possible, I'd welcome it if it can be merged after this series.

-michael


More information about the U-Boot mailing list