[PATCH v4 4/7] sandbox: Add a DSA sandbox driver and unit test

[Vladimir Oltean]

On Tue, Feb 16, 2021 at 04:38:06PM -0500, Tom Rini wrote:
> On Tue, Feb 16, 2021 at 10:33:37PM +0100, Michael Walle wrote:
> > Am 2021-02-16 22:21, schrieb Vladimir Oltean:
> > > On Tue, Feb 16, 2021 at 04:13:41PM -0500, Tom Rini wrote:
> > > > On Tue, Feb 16, 2021 at 11:02:25PM +0200, Vladimir Oltean wrote:
> > > > > Hi Tom,
> > > > >
> > > > > On Tue, Feb 16, 2021 at 01:14:57PM -0500, Tom Rini wrote:
> > > > > > This test does not pass for me.  This can be seen at:
> > > > > > https://gitlab.denx.de/u-boot/u-boot/-/jobs/223660
> > > > > >
> > > > > > Note that I'm still reviewing the rest of the series right now.
> > > > >
> > > > > You're right, thanks for letting me know.
> > > > > I've fixed this in my tree [ by adding two more patches :-/ ], let me
> > > > > know if you have any other feedback, otherwise I'm going to resend soon.
> > > >
> > > > I'm about to push the rest of the series, so you can rebase on master
> > > > shortly, thanks!  Or should I hold off as this exposed problems in the
> > > > rest of your series?
> > >
> > > Sorry, I missed your reply earlier. I just sent out a new version which
> > > should be sandbox-clean and which also makes the fixed PHY driver
> > > compatible with live OF, since that's what the problem was, essentially.
> >
> > If this series is merged, I'd just send a follow up for the kontron sl28
> > board device tree, which also uses DSA. Originally, this it wasn't
> > possible to include the patch in this series, because there was still
> > the base device tree for this board variant pending in u-boot.
> >
> > So if possible, I'd welcome it if it can be merged after this series.
>
> OK, so I guess there's a small amount of follow-up to finish enabling it
> as I see, today with v4:
> kontron_sl28   : all +9467 bss +2560 data +568 rodata +675 spl/u-boot-spl:all +18 spl/u-boot-spl:rodata +18 text +5664
>
> when building and it's on just a few layerscape platforms so I assumed
> it was enabling everything.
>
> And, I'm inclined to go with reposting just a follow-up that fixes /
> enables sandbox and livetree as I would like to both:
> - Not delay the whole thing further
> - Not merge other changes immediately after they're posted[*]
>
> --
> Tom
>
> [*]: Yes, I did this literally yesterday, but for a security series I
> had seen prior, so a special case I don't like either, but... anyhow.

Tom, if you want to merge v4 sans the sandbox support instead of v5, I'm
okay with that. I can easily send out the v5 changes in a follow-up series.