[PATCH v4 4/7] sandbox: Add a DSA sandbox driver and unit test

[Michael Walle]

Am 2021-02-16 22:38, schrieb Tom Rini:
> On Tue, Feb 16, 2021 at 10:33:37PM +0100, Michael Walle wrote:
>> Am 2021-02-16 22:21, schrieb Vladimir Oltean:
>> > On Tue, Feb 16, 2021 at 04:13:41PM -0500, Tom Rini wrote:
>> > > On Tue, Feb 16, 2021 at 11:02:25PM +0200, Vladimir Oltean wrote:
>> > > > Hi Tom,
>> > > >
>> > > > On Tue, Feb 16, 2021 at 01:14:57PM -0500, Tom Rini wrote:
>> > > > > This test does not pass for me.  This can be seen at:
>> > > > > https://gitlab.denx.de/u-boot/u-boot/-/jobs/223660
>> > > > >
>> > > > > Note that I'm still reviewing the rest of the series right now.
>> > > >
>> > > > You're right, thanks for letting me know.
>> > > > I've fixed this in my tree [ by adding two more patches :-/ ], let me
>> > > > know if you have any other feedback, otherwise I'm going to resend soon.
>> > >
>> > > I'm about to push the rest of the series, so you can rebase on master
>> > > shortly, thanks!  Or should I hold off as this exposed problems in the
>> > > rest of your series?
>> >
>> > Sorry, I missed your reply earlier. I just sent out a new version which
>> > should be sandbox-clean and which also makes the fixed PHY driver
>> > compatible with live OF, since that's what the problem was, essentially.
>> 
>> If this series is merged, I'd just send a follow up for the kontron 
>> sl28
>> board device tree, which also uses DSA. Originally, this it wasn't
>> possible to include the patch in this series, because there was still
>> the base device tree for this board variant pending in u-boot.
>> 
>> So if possible, I'd welcome it if it can be merged after this series.
> 
> OK, so I guess there's a small amount of follow-up to finish enabling 
> it
> as I see, today with v4:
> kontron_sl28   : all +9467 bss +2560 data +568 rodata +675
> spl/u-boot-spl:all +18 spl/u-boot-spl:rodata +18 text +5664

The support was already enabled, but the device tree for this
partitcular variant was still missing when this patchset was posted.
Therefore, it couldn't be enabled.

commit b463010be067ba4b8ef9b7b80919f592a0f83bfb
Author: Michael Walle <michael at walle.cc>
Date:   Fri Jan 8 00:08:58 2021 +0100

     board: sl28: add network variant 2 support

     Although this variant has two external network ports, they are not 
(yet)
     supported by the bootloader because they are connected via an 
internal
     network switch. Otherwise its the same as the other variants.

     Signed-off-by: Michael Walle <michael at walle.cc>
     Reviewed-by: Priyanka Jain <priyanka.jain at nxp.com>

So the only thing which is missing is device tree fragment.

> when building and it's on just a few layerscape platforms so I assumed
> it was enabling everything.
> 
> And, I'm inclined to go with reposting just a follow-up that fixes /
> enables sandbox and livetree as I would like to both:
> - Not delay the whole thing further
> - Not merge other changes immediately after they're posted[*]

I just tried it again on my board and there seems still to be something
broken :( I just don't have time right now. Would it be OK, to delay
this until tomorrow?

-michael