[PATCH v5] net: tftp: Add client support for RFC 7440

[Oliver Graute]

On 18/07/20, Ramon Fried wrote:
> Add support for RFC 7440: "TFTP Windowsize Option".
> 
> This optional feature allows the client and server
> to negotiate a window size of consecutive blocks to send as an
> alternative for replacing the single-block lockstep schema.
> 
> windowsize can be defined statically during compilation by
> setting CONFIG_TFTP_WINDOWSIZE, or defined in runtime by
> setting an environment variable: "tftpwindowsize"
> If not defined, the windowsize is set to 1, meaning that it
> behaves as it was never defined.

this commit breaks my TFTP Setup. I run into lot of timeouts and most of
the times I can't load the kernel or the dtb.

Using ethernet at 5b040000 device
TFTP from server 192.168.100.99; our IP address is 192.168.100.96
Filename 'Image'.
Load address: 0x80280000
Loading: #T T T T T T T

On bisecting between 2020.07 and 2020.10 I stumbled across this commit.
reverting it fix the issue immediately.

Some clue why the default windowsize set 1 breaks it for me?

Best regards,

Oliver