[PATCH] fdt/sunxi: Remove OF_STDOUT_PATH

Simon Glass sjg at chromium.org
Fri Feb 19 05:52:25 CET 2021


Hi Andre,

On Thu, 18 Feb 2021 at 09:03, Andre Przywara <andre.przywara at arm.com> wrote:
>
> On Wed, 17 Feb 2021 21:45:29 -0700
> Simon Glass <sjg at chromium.org> wrote:
>
> Hi Simon,
>
> > On Sun, 14 Feb 2021 at 05:35, Andre Przywara <andre.przywara at arm.com> wrote:
> > >
> > > OF_STDOUT_PATH was meant to hold the devicetree path to the serial
> > > console, to be put into the linux,stdout-path property of the chosen node.
> > >
> > > The only user of that was sunxi, and it was actually wrong for years
> > > there: the paths hardcoded in sunxi_common.h were not matching the DTs,
> > > evident by the leading 0's in nodenames, which have been removed years
> > > ago.
> > >
> > > On top of that, "linux,stdout-path" is now deprecated for a while (Linux
> > > commit 2a9d832cc9aae from November 2014), and also all modern DTs
> > > (including those included in U-Boot) carry a "stdout-path" property
> > > already.
> > >
> > > So remove the stanza from sunxi_common.h, and, since this was the last
> > > user, also remove the associated bits from the rest of U-Boot.
> > >
> > > Signed-off-by: Andre Przywara <andre.przywara at arm.com>
> > > ---
> > >  README                         |  1 -
> > >  common/fdt_support.c           |  9 +--------
> > >  include/configs/sunxi-common.h | 18 ------------------
> > >  scripts/config_whitelist.txt   |  1 -
> > >  4 files changed, 1 insertion(+), 28 deletions(-)
> > >
> >
> > You should teach a class in how to write commit messages :-)
>
> Thanks :blush:
>
> > Reviewed-by: Simon Glass <sjg at chromium.org>
>
> Thanks, shall I take this patch through the sunxi tree (I have a PR
> ready anyway), or do you want to take it?

Please go ahead with sunxi.

Regards,
Simon


More information about the U-Boot mailing list