[PATCH 08/10] sun5i: add support for DIP detection to CHIP board

[Andre Przywara]

On Fri, 19 Feb 2021 11:54:54 -0500
Tom Rini <trini at konsulko.com> wrote:

Hi,

> On Thu, Feb 18, 2021 at 02:29:36PM +0100, Kory Maincent wrote:
> 
> > Add the extension_board_scan specific function to scan the information
> > of the EEPROM on one-wire and fill the extension struct.
> > 
> > Signed-off-by: Kory Maincent <kory.maincent at bootlin.com>
> > ---
> >  arch/arm/mach-sunxi/Kconfig |   2 +
> >  board/sunxi/Makefile        |   1 +
> >  board/sunxi/chip.c          | 104 ++++++++++++++++++++++++++++++++++++
> >  3 files changed, 107 insertions(+)
> >  create mode 100644 board/sunxi/chip.c
> > 
> > diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
> > index 37a4294d88..3bb8a08b34 100644
> > --- a/arch/arm/mach-sunxi/Kconfig
> > +++ b/arch/arm/mach-sunxi/Kconfig
> > @@ -6,10 +6,12 @@ choice
> >  
> >  config TARGET_CHIP
> >  	bool "CHIP board"
> > +	select SUPPORT_EXTENSION_SCAN
> >  	select W1
> >  	select W1_GPIO
> >  	select W1_EEPROM
> >  	select W1_EEPROM_DS24XXX
> > +	imply CMD_EXTENSION  
> 
> And then based on my comment in the previous patch, similar to
> PINEPHONE_DT_SELECTION and other board-specific options, add a
> CHIP_DIP_SCAN option or similar.

Yes, indeed, thanks Tom.

The idea of making this extension scheme generic is great, it's just
that sunxi is using a different approach to board specific code here.
Normally we expect U-Boot-proper board specific code to be DT driven,
and where this does not really work, use those symbols that Tom pointed
to.

Thanks,
Andre