[EXT] USB3 XHCI crashing with USB 3 hub on Octeon

[Stefan Roese]

On 23.02.21 11:36, Mark Kettenis wrote:
>> From: Nicolas Saenz Julienne <nsaenzjulienne at suse.de>
>> Date: Tue, 23 Feb 2021 10:23:04 +0100
>>
>> On Tue, 2021-02-23 at 09:15 +0100, Stefan Roese wrote:
>>> Hi Bin,
>>> Hi Aaron,
>>>
>>> I've added Nicolas to Cc, as he also recently did some work on the
>>> physical vs virtual addresses in the xHCI driver.
>>>
>>> On 23.02.21 09:07, Bin Meng wrote:
>>>> Hi Aaron,
>>>>
>>>> On Tue, Feb 23, 2021 at 3:31 PM Aaron Williams <awilliams at marvell.com> wrote:
>>>>>
>>>>> I have a follow-up. USB is working on our OcteonTX boards running 2020.10. It
>>>>> may be something specific to the Octeon port. Note that I did see a problem
>>>>> where the scratchpad memory is using direct pointers instead of physical
>>>>> addresses (which will not work on MIPS). As far as I know, however, the Octeon
>>>>> XHCI controller does not use the scratchpad memory.
>>>>>
>>>>
>>>> Do you plan to send a patch to convert the scratchpad pointer to
>>>> physical address?
>>>
>>> Nicolas, did your patch also address the scratchpad area (sorry for not
>>> looking myself).
>>
>> Yes, my patch took care of that :).
> 
> Ah cool.  I missed that patch.  Looks like this is exactly what I need
> to cater for the translation done by the IOMMU on the Apple M1.
> 
> Won't be sending that patch then ;)

Nice.

Aaron, it might be that you missed this patch series with your latest
mainline xHCI tests a few days ago. Could you please try again with
current mainline and report back, if this changes the behavior on
Octeon MIPS with USB3 hubs?

Thanks,
Stefan