[PATCH 08/10] sun5i: add support for DIP detection to CHIP board

[Köry Maincent]

Hello Andre,

On Tue, 23 Feb 2021 13:30:38 +0000
Andre Przywara <andre.przywara at arm.com> wrote:
y extension_board_scan board specific function, would you prefer if I
> > move to callback like below instead of Kconfig?
> > 
> > if (of_machine_is_compatible("nextthing,chip"))
> > 	extension_board_register_callback(chip_extension_board_scan);  
> 
> Well, the CHIP Pro uses a different compatible string, so you would
> need to check for that too.
> I am not fully decided if checking for the machine compatible is the
> right approach. The more traditional U-Boot way would be to define a
> config symbol (as Tom already pointed out), that would also keep the
> code out of other board builds.
> We do this already with CONFIG_PINE64_DT_SELECTION and
> CONFIG_PINEPHONE_DT_SELECTION.

Okay, I will move on to the traditional config symbol.

Thanks.

Köry