[RFC PATCH 1/2] net: dsa: return early if there is no master

[Michael Walle]

Am 2021-02-23 17:32, schrieb Vladimir Oltean:
> On Tue, Feb 23, 2021 at 05:19:05PM +0100, Michael Walle wrote:
>> It doesn't make sense to have DSA without a master port. Error out 
>> early
>> if there is no master port.
>> 
>> Fixes: fc054d563bfb ("net: Introduce DSA class for Ethernet switches")
>> Signed-off-by: Michael Walle <michael at walle.cc>
>> ---
> 
> Reviewed-by: Vladimir Oltean <vladimir.oltean at nxp.com>
> 
> I think you can also be more aggressive and remove the checks:
> 
> 	if (!master)
> 		return -EINVAL;
> 
> from dsa_port_send and dsa_port_recv. At least it sounds broken to me
> that this could ever happen.

Yep, I've seen these, too. I'll send a non-RFC version and remove these.

-michael