[PATCH] Fix IDE commands issued, fix endian issues, fix non MMIO

Tom Rini trini at konsulko.com
Wed Feb 24 20:41:18 CET 2021


On Wed, Feb 24, 2021 at 06:57:08PM +0100, Heinrich Schuchardt wrote:
> On 24.02.21 17:44, Reinoud Zandijk wrote:
> >
> > Fixes IDE issues found on the Malta board under Qemu:
> >
> > 1) DMA implied commands were sent to the controller in stead of the PIO
> > variants. The rest of the code is DMA free and written for PIO operation.
> >
> > 2) direct pointer access was used to read and write the registers instead
> > of the inb/inw/outb/outw functions/macros. Registers don't have to be
> > memory mapped and ATA_CURR_BASE() does not have to return an offset from
> > address zero.
> >
> > 3) Endian isues in ide_ident() and reading/writing data in general. Names
> > were corrupted and sizes misreported.
> 
> It is preferable to have each issue fixed in a separate patch.
> 
> >
> > Tested malta_defconfig and maltael_defconfig to work again in Qemu.
> 
> What about the other architectures which can use the driver?
> 
> @Simon:
> Can we get rid of U_BOOT_LEGACY_BLK(ide)?

The various "remove ..." board series I've been sending cover the block
case too, so after v2021.04 and once I've applied the "remove ..."
series stuff, yes, I think so.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210224/85b49091/attachment.sig>


More information about the U-Boot mailing list