[PATCH 4/4] net: dsa: remove master santiy check

Vladimir Oltean olteanv at gmail.com
Wed Feb 24 23:25:52 CET 2021


On Wed, Feb 24, 2021 at 05:40:42PM +0100, Michael Walle wrote:
> Because we probe the master ourselves (and fail if there is no master),
> it is not possible that we don't have a master device.
> 
> There is one catch though: device removal. We don't support that. It
> wasn't supported neither before this patch. Because the master device
> was only set in .pre_probe(), if a device was removed master_dev was a
> dangling pointer and transmitting a frame cause a panic. I don't see a
> good solution without having some sort of notify machanism when a
> udevice is removed.
> 
> Signed-off-by: Michael Walle <michael at walle.cc>
> ---

U-Boot DM maintainers might want to comment on this as well, but with
the knowledge I have this seems good enough to me:

Reviewed-by: Vladimir Oltean <vladimir.oltean at nxp.com>


More information about the U-Boot mailing list