[EXT] Re: [PATCH 4/4] imx8mq_evk: Enable the USB3.0 host port

[Ye Li]

Hi Fabio,

On Thu, 2021-02-25 at 08:01 -0300, Fabio Estevam wrote:
> Caution: EXT Email
> 
> Hi Ye Li,
> 
> On Thu, Feb 25, 2021 at 3:36 AM Ye Li <ye.li at nxp.com> wrote:
> > 
> > 
> > Setup USB clock in board codes, and enable the DWC3 XHCI and
> > PHY drivers to make USB3.0 host port working on i.MX8MQ EVK.
> > 
> > Signed-off-by: Ye Li <ye.li at nxp.com>
> Thanks for the patch.
> 
> Have you tested it in the imx8mq-evk using the latest U-Boot master
> branch?
> 
> The reason I am asking is that imx8mq-evk does not even boot for me
> unless I apply the following two patches:
> 
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flis
> ts.denx.de%2Fpipermail%2Fu-boot%2F2021-
> February%2F441971.html&data=04%7C01%7Cye.li%40nxp.com%7C16ed6adce
> 72548e2c57e08d8d97cbf71%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C
> 637498477099446700%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIj
> oiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=10PTxobzvXV
> UaVhn1Rv1yM5xe0uZk3aluha81cPAK%2Fc%3D&reserved=0
> 
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flis
> ts.denx.de%2Fpipermail%2Fu-boot%2F2021-
> February%2F441988.html&data=04%7C01%7Cye.li%40nxp.com%7C16ed6adce
> 72548e2c57e08d8d97cbf71%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C
> 637498477099446700%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIj
> oiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=lyG6qFbrKVf
> vMjii3vS5fZ3DQTbxinqms%2FO4D1yX4l4%3D&reserved=0
> 
> Please advise.

Sure, I have tested it on 8mq evk. I can reproduce the two issues you
met. 
The first issue is caused by the ALIGN. The implementation of standard
ALIGN requires the aligned size to be power of 2. But the ALIGN in
imx8mimage does not have this requirement. So below result is wrong by
using the standard ALIGN. Your fix should be OK for this issue. 

file_off += ALIGN(sbuf.st_size, HDMI_FW_SIZE + 0x2000 + 0x1000);


For the second issue, I did not debug into it. But our vendor tree also
uses off-on-delay-us in both u-boot and kernel. So it is likely caused
by other change. 


Attach the log of usb host test.

U-Boot SPL 2021.04-rc2-00059-g1784e9b (Feb 21 2021 - 14:35:00 -0800)
PMIC:  PFUZE100 ID=0x10
Normal Boot
Trying to boot from MMC2
E/TC:0 0 caam_mp_init:364 *************************************
E/TC:0 0 caam_mp_init:365 * Warning: Manufacturing protection *
E/TC:0 0 caam_mp_init:366 *          is not supported         *
E/TC:0 0 caam_mp_init:367 *************************************


U-Boot 2021.04-rc2-00059-g1784e9b (Feb 21 2021 - 14:35:00 -0800)

CPU:   Freescale i.MX8MQ rev2.0 at 1000 MHz
Reset cause: POR
Model: NXP i.MX8MQ EVK
DRAM:  3 GiB
MMC:   FSL_SDHC: 0, FSL_SDHC: 1
Loading Environment from MMC... *** Warning - No block device, using
default environment

In:    serial
Out:   serial
Err:   serial
Net:   eth0: ethernet at 30be0000
Hit any key to stop autoboot:  0
u-boot=> usb start
starting USB...
Bus usb at 38200000: Register 2000140 NbrPorts 2
Starting the controller
USB XHCI 1.10
scanning bus usb at 38200000 for devices... cannot reset port 1!?
2 USB Device(s) found
       scanning usb for storage devices... 1 Storage Device(s) found
u-boot=> usb dev

IDE device 0: Vendor: Kingston Rev:  Prod: DataTraveler 3.0
            Type: Removable Hard Disk
            Capacity: 14755.2 MB = 14.4 GB (30218842 x 512)
u-boot=> usb read 0x40480000 0x0 0x1000

usb read: device 0 block # 0, count 4096 ... 4096 blocks read: OK


Best regards,
Ye Li