[PATCH u-boot-marvell 3/5] pci: pci_mvebu: debug rd/wr config as other drivers do

Stefan Roese sr at denx.de
Fri Feb 26 10:12:26 CET 2021


On 08.02.21 23:01, Marek Behún wrote:
> Other drivers (aardvark, intel_fpga) print "(addr,size,val)" when
> debugging is enabled. Print size for pci_mvebu as well.
> 
> Signed-off-by: Marek Behún <marek.behun at nic.cz>
> Cc: Stefan Roese <sr at denx.de>
> Cc: Phil Sutter <phil at nwl.cc>
> Cc: Mario Six <mario.six at gdsys.cc>
> Cc: Baruch Siach <baruch at tkos.co.il>

Reviewed-by: Stefan Roese <sr at denx.de>

Thanks,
Stefan

> ---
>   drivers/pci/pci_mvebu.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/pci_mvebu.c b/drivers/pci/pci_mvebu.c
> index abc6e9e6e0..4ad73512a6 100644
> --- a/drivers/pci/pci_mvebu.c
> +++ b/drivers/pci/pci_mvebu.c
> @@ -174,7 +174,7 @@ static int mvebu_pcie_read_config(const struct udevice *bus, pci_dev_t bdf,
>   
>   	/* read data */
>   	data = readl(pcie->base + PCIE_CONF_DATA_OFF);
> -	debug("(addr,val)=(0x%04x, 0x%08x)\n", offset, data);
> +	debug("(addr,size,val)=(0x%04x, %d, 0x%08x)\n", offset, size, data);
>   	*valuep = pci_conv_32_to_size(data, offset, size);
>   
>   	return 0;
> @@ -191,7 +191,7 @@ static int mvebu_pcie_write_config(struct udevice *bus, pci_dev_t bdf,
>   
>   	debug("PCIE CFG write: loc_bus=%d loc_dev=%d (b,d,f)=(%2d,%2d,%2d) ",
>   	      local_bus, local_dev, PCI_BUS(bdf), PCI_DEV(bdf), PCI_FUNC(bdf));
> -	debug("(addr,val)=(0x%04x, 0x%08lx)\n", offset, value);
> +	debug("(addr,size,val)=(0x%04x, %d, 0x%08lx)\n", offset, size, value);
>   
>   	/* Don't access the local host controller via this API */
>   	if (PCI_BUS(bdf) == local_bus && PCI_DEV(bdf) == local_dev) {
> 


Viele Grüße,
Stefan

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de


More information about the U-Boot mailing list