[PATCH v3 31/38] dm: sysreset: Add a Kconfig option for the 'reset' command

[Priyanka Jain (OSS)]

>-----Original Message-----
>From: U-Boot <u-boot-bounces at lists.denx.de> On Behalf Of Bin Meng
>Sent: Thursday, February 25, 2021 2:53 PM
>To: Simon Glass <sjg at chromium.org>; Alexander Graf <agraf at csgraf.de>;
>Priyanka Jain <priyanka.jain at nxp.com>
>Cc: U-Boot Mailing List <u-boot at lists.denx.de>; Tom Rini
><trini at konsulko.com>
>Subject: [PATCH v3 31/38] dm: sysreset: Add a Kconfig option for the 'reset'
>command
>
>sysreset uclass driver provides an implementation of 'reset'
>command using the sysreset_ APIs unconditionally. It also supports the
>'poweroff' command using the sysreset_ APIs, but under a Kconfig option
>CONFIG_SYSRESET_CMD_POWEROFF.
>
>Let's do the same for the 'reset' command, by introducing a new Kconfig
>option CONFIG_SYSRESET_CMD_RESET, and set it to on by default, to allow a
>board that don't have a sysreset reset driver yet, but have a sysreset
>poweroff driver to compile without any issue.
>
>Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>Reviewed-by: Simon Glass <sjg at chromium.org>
>Reviewed-by: Priyanka Jain <priyanka.jain at nxp.com>
>
>---
>
>(no changes since v2)
>
>Changes in v2:
>- new patch: dm: sysreset: Add a Kconfig option for the 'reset' command
>
> drivers/sysreset/Kconfig           | 6 ++++++
> drivers/sysreset/sysreset-uclass.c | 2 ++
> 2 files changed, 8 insertions(+)
>
>diff --git a/drivers/sysreset/Kconfig b/drivers/sysreset/Kconfig index
>0e5c7c9..968dfa4 100644
>--- a/drivers/sysreset/Kconfig
>+++ b/drivers/sysreset/Kconfig
>@@ -33,6 +33,12 @@ config TPL_SYSRESET
>
> if SYSRESET
>
>+config SYSRESET_CMD_RESET
>+	bool "sysreset implementation of the reset command"
>+	default y
>+	help
>+	  Enable sysreset implementation of the reset command.
>+
> if CMD_POWEROFF
>
> config SYSRESET_CMD_POWEROFF
>diff --git a/drivers/sysreset/sysreset-uclass.c b/drivers/sysreset/sysreset-
>uclass.c
>index a9908eb..6c9dc7a 100644
>--- a/drivers/sysreset/sysreset-uclass.c
>+++ b/drivers/sysreset/sysreset-uclass.c
>@@ -119,6 +119,7 @@ void reset_cpu(ulong addr)  }
>
>
>+#if IS_ENABLED(CONFIG_SYSRESET_CMD_RESET)
> int do_reset(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])  {
> 	printf("resetting ...\n");
>@@ -128,6 +129,7 @@ int do_reset(struct cmd_tbl *cmdtp, int flag, int argc,
>char *const argv[])
>
> 	return 0;
> }
>+#endif
>
> #if IS_ENABLED(CONFIG_SYSRESET_CMD_POWEROFF)
> int do_poweroff(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
>--
>2.7.4

Kindly fix below if possible

WARNING: please write a paragraph that describes the config symbol fully
#34: FILE: drivers/sysreset/Kconfig:36:
+config SYSRESET_CMD_RESET

WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where possible
#51: FILE: drivers/sysreset/sysreset-uclass.c:122:
+#if IS_ENABLED(CONFIG_SYSRESET_CMD_RESET)

total: 0 errors, 2 warnings, 0 checks, 26 lines checked

Regards
Priyanka